Bazel: choose tags or commit, when parsing dependencies.yaml #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golovasteek
force-pushed
the
bazel/make_choose_tags_or_commit_automatically
branch
from
6a05978
to
9b7e856
Compare
….yaml Now bazel dep_tool, Is able to decide if the commit or tag is used as a reference and generate the *.bzl files accordingly. There is a limitiation: commit should we always be a full 40-character string, otherwise it's treated as a tag. Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
golovasteek
force-pushed
the
bazel/make_choose_tags_or_commit_automatically
branch
from
9b7e856
to
3f16961
Compare
|
This should prevent issues like this one: #652 (comment) |
golovasteek
requested review from
SirVer,
dorezyuk,
Pietfried,
hikinggrass and
corneliusclaussen
as code owners
dorezyuk
approved these changes
Apr 30, 2024
hikinggrass
approved these changes
May 8, 2024
hikinggrass
reviewed
May 8, 2024
|
Looks like your last commit addressing the comment in dependencies.yaml is missing the DCO sign-off, once that's sorted this can be merged |
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
golovasteek
force-pushed
the
bazel/make_choose_tags_or_commit_automatically
branch
from
30f6d52
to
2350601
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Now bazel dep_tool, Is able to decide if the commit or tag is used as a reference and generate the *.bzl files accordingly.
There is a limitation: commit should we always be a full 40-character string, otherwise it's treated as a tag.
Issue ticket number and link
Checklist before requesting a review