MaEVe setChargingProfile Support #55
Conversation
…ing profile. Also added a script that will make that API request for us Signed-off-by: louisg1337 <louisgrassi1337@gmail.com>
…pends on specific SHA of a commit on the main, so handle accordingly Signed-off-by: louisg1337 <louisgrassi1337@gmail.com>
There was a problem hiding this comment.
This is what I had requested, and I am going to merge it.
However, the next polishing change is to change both demo scripts to take in charging profiles as JSON files. We can then hook up the "Appenzell" project that validates profiles and show the resulting composite schedules, to this.
e.g. https://github.com/US-JOET/base-camp/issues/149
demo-iso15118-2-ac-plus-ocpp.sh
Outdated
| @@ -93,7 +94,7 @@ git clone --branch "${DEMO_BRANCH}" "${DEMO_REPO}" everest-demo | |||
|
|
|||
| if [[ "$DEMO_VERSION" != v1.6j ]]; then | |||
| echo "Cloning ${CSMS} CSMS from ${CSMS_REPO} into ${DEMO_DIR}/${CSMS}-csms and starting it" | |||
| git clone ${CSMS_REPO} ${CSMS}-csms | |||
| git clone --branch "${CSMS_BRANCH}" "${CSMS_REPO}" ${CSMS}-csms | |||
There was a problem hiding this comment.
This is fine, but then I think you can remove line 101
| @@ -176,6 +177,7 @@ if [[ "$DEMO_VERSION" != v1.6j ]]; then | |||
| fi | |||
| fi | |||
|
|
|||
| docker compose build | |||
There was a problem hiding this comment.
I am not sure we want to make people build every time - the demo was supposed to be for people to quickly see how things work. But I see how it can also confuse people if they don't rebuild. I will merge this now, but we may want to think about dev versus run flows and how we should document them,
Added in support for
setChargingProfilein MaEVe, so changed the demo script to point to my repo. Also added a script that will make the API call for us.