OCPP2.0.1: Device model access for EVSE and Connector specific variables #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enhanced integrity check of device model by checking correct number of EVSE and Connectors * DM Availability state and Power is updated at runtime Signed-off-by: pietfried <pietgoempel@gmail.com>
Pietfried
requested review from
hikinggrass,
marcemmers and
maaikez
as code owners
hikinggrass
reviewed
Apr 8, 2024
| const Component& CustomizationCtrlr = {"CustomizationCtrlr"}; | ||
| const Component& DeviceDataCtrlr = {"DeviceDataCtrlr"}; | ||
| const Component& DisplayMessageCtrlr = {"DisplayMessageCtrlr"}; | ||
| const Component& EVSE = {"EVSE"}; | ||
| const Component& ISO15118Ctrlr = {"ISO15118Ctrlr"}; | ||
| const Component& ISO15118Ctrlr = {"ISO15118Ctrlr"}; // dynamic? |
There was a problem hiding this comment.
A question to self :D Will possibly need to be dynamic based on nr of evses in the future, will remove for now
Pietfried
commented
Apr 8, 2024
Signed-off-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com>
hikinggrass
approved these changes
Apr 8, 2024
marcemmers
approved these changes
Apr 10, 2024
include/ocpp/v201/utils.hpp
Outdated
| @@ -61,6 +61,9 @@ std::string generate_token_hash(const IdToken& token); | |||
| /// \return DateTime type timestamp | |||
| ocpp::DateTime align_timestamp(const DateTime timestamp, std::chrono::seconds align_interval); | |||
|
|
|||
| /// \brief Returns the total Power_Active_Import value from the \p meter_value or 0 if it is not present | |||
| float get_total_power_active_import(const MeterValue& meter_value); | |||
There was a problem hiding this comment.
I would suggest to return an optional here if not found. A power of 0W is a very valid value when idle.
Signed-off-by: pietfried <pietgoempel@gmail.com>
3 tasks
folkengine
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Apr 15, 2024
…les (EVerest#553) * Implemented dm access for EVSE and Connector * Enhanced integrity check of device model by checking correct number of EVSE and Connectors * DM Availability state and Power is updated at runtime --------- Signed-off-by: pietfried <pietgoempel@gmail.com> Signed-off-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
#529
Checklist before requesting a review