Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing tweaks for block content #49

Merged
merged 1 commit into from
Mar 28, 2015

Conversation

sharwell
Copy link
Contributor

@EWSoftware
Copy link
Owner

I'm okay with indenting the collapsible section content. I don't like the other spacing changes. The problem is that you are addressing one specific use that doesn't like right to you. The problem is that anything with normal paragraphs get bunched up with no separation making it harder to read (content with actual paragraphs not "-or-" separators). If you don't want paragraphs, use line breaks instead to get the desired spacing in those cases.

@sharwell
Copy link
Contributor Author

Let me play with this one for a bit. The "vstudio" theme on MSDN used to use this spacing in exception tables, but they no longer do. The use of <p> elements for each line is commonplace. I'll update this pull request soon.

References:

List<T>.InsertRange
List<T>.InsertRange ("vstudio" theme)

@sharwell
Copy link
Contributor Author

I updated this to restore spacing between paragraphs in a table. If you are still uncomfortable with this, just let me know and I'll split it into two pull requests (one for the collapsible sections and one for the paragraphs).

@EWSoftware
Copy link
Owner

I'll only merge the collapsible section change. I'm not interested in the paragraph spacing changes so there's no need for a separate pull request for them, they can just be reverted.

@sharwell
Copy link
Contributor Author

Done 👍

EWSoftware added a commit that referenced this pull request Mar 28, 2015
Spacing tweaks for block content
@EWSoftware EWSoftware merged commit 371785a into EWSoftware:master Mar 28, 2015
@sharwell sharwell deleted the spacing-tweaks branch March 28, 2015 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants