Ft correction changes #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should also remove the caluclation of any "Rs" term at this stage to avoid confusion
I think we still need to figure out how to handle minerals other than zircon and apatite
I didn't change anything here, just noted that the Ft values and uncertainties need to reference the corrected values we calculated in the icpms importer
|
At this point, I'm partially through converting some of the most important parts of the calculation to "real" Python code. There are lots of details so it would be useful if @Jim-Metcalf could check for typos. As mentioned in email, it would also be useful to define a few tests of input/output for these corrected Ft calculations. That way, we could prove the code correct without having to rerun the whole data production in Sparrow. |
Open
|
Superseded (again) by #10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates changes from @Jim-Metcalf to improve calculation of Ft values + errors. Supersedes #1.