minor #382 Fixed minor issues reported by Scrutinizer (javiereguiluz)

This PR was squashed before being merged into the master branch (closes #382). Discussion ---------- Fixed minor issues reported by Scrutinizer Commits ------- 28dbba1 Fixed minor issues reported by Scrutinizer
EasyCorp · Jul 7, 2015 · 0b5e26a · 0b5e26a
2 parents 418a2ad + 28dbba1
commit 0b5e26a
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/DependencyInjection/EasyAdminExtension.php b/DependencyInjection/EasyAdminExtension.php
@@ -565,6 +565,6 @@ private function normalizeFieldsConfiguration(array $fieldsConfiguration, $view,
      */
     private function isValidMethodName($name)
     {
-        return preg_match('/^-?[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*$/', $name, $matches);
+        return 0 !== preg_match('/^-?[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*$/', $name);
     }
 }
diff --git a/Listener/ExceptionListener.php b/Listener/ExceptionListener.php
@@ -41,6 +41,7 @@ public function onKernelException(GetResponseForExceptionEvent $event)
             'EntityNotFoundException' => '@EasyAdmin/error/entity_not_found.html.twig',
         );
 
+        /** @var \JavierEguiluz\Bundle\EasyAdminBundle\Exception\BaseException */
         $exception = $event->getException();
         $exceptionClassName = basename(str_replace('\\', '/', get_class($exception)));
 

diff --git a/Tests/Controller/ReadOnlyBackendTest.php b/Tests/Controller/ReadOnlyBackendTest.php
@@ -11,6 +11,7 @@
 
 namespace JavierEguiluz\Bundle\EasyAdminBundle\Tests\Controller;
 
+use Symfony\Component\DomCrawler\Crawler;
 use JavierEguiluz\Bundle\EasyAdminBundle\Tests\Fixtures\AbstractTestCase;
 use JavierEguiluz\Bundle\EasyAdminBundle\Exception\NoEntitiesConfiguredException;
 
@@ -49,15 +50,15 @@ public function testShowViewContaisNoDisabledActions()
 
     public function testEditActionIsDisabled()
     {
-        $crawler = $this->requestEditView();
+        $this->requestEditView();
 
         $this->assertEquals(500, $this->client->getResponse()->getStatusCode());
         $this->assertContains('The requested edit action is not allowed.', $this->client->getResponse()->getContent());
     }
 
     public function testNewActionIsDisabled()
     {
-        $crawler = $this->requestNewView();
+        $this->requestNewView();
 
         $this->assertEquals(500, $this->client->getResponse()->getStatusCode());
         $this->assertContains('The requested new action is not allowed.', $this->client->getResponse()->getContent());

diff --git a/Tests/Fixtures/AbstractTestCase.php b/Tests/Fixtures/AbstractTestCase.php
@@ -51,8 +51,6 @@ protected function getBackendPage(array $parameters)
     }
 
     /**
-     * @param array $parameters
-     *
      * @return Crawler
      */
     protected function getBackendHomepage()

diff --git a/Tests/Fixtures/AppTestBundle/DataFixtures/ORM/LoadProducts.php b/Tests/Fixtures/AppTestBundle/DataFixtures/ORM/LoadProducts.php
@@ -73,7 +73,7 @@ public function getRandomEan()
         $count = count($chars) - 1;
         $ean13 = '';
         do {
-            $ean13 .= $char = $chars[rand(0, $count)];
+            $ean13 .= $chars[rand(0, $count)];
         } while (strlen($ean13) < 13);
 
         $checksum = 0;