Skip to content

Commit

Permalink
feature #4526 Replaced deprecated node-sass with sass (skmedix)
Browse files Browse the repository at this point in the history
This PR was squashed before being merged into the 3.0.x-dev branch.

Discussion
----------

Replaced deprecated `node-sass` with `sass`

Since Bootstrap 5, recommended is to use [`sass`](https://www.npmjs.com/package/sass) library, as [`node-sass` is deprecated](https://sass-lang.com/blog/libsass-is-deprecated).

I also fixed one deprecation warning about passing value without a unit. (I can split this into a different PR if needed)

Commits
-------

7a46150 Replaced deprecated `node-sass` with `sass`
  • Loading branch information
javiereguiluz committed Aug 3, 2021
2 parents 8dd6b78 + 7a46150 commit 445103f
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 873 deletions.
2 changes: 1 addition & 1 deletion assets/css/easyadmin-theme/variables-bootstrap.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ $input-bg-disabled: var(--gray-100);
$input-color: var(--text-color-dark);
$input-border: var(--border-color);
$input-border-radius: var(--border-radius);
$input-border-focus: hsla(201, 94, 37, 0.2);
$input-border-focus: hsla(201, 94%, 37%, 0.2);
$input-color-placeholder: var(--gray-600);
$input-height-base: 30px;
$form-check-input-checked-bg-color: $primary;
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"dirty-form": "^0.4.0",
"file-loader": "^6.0.0",
"mark.js": "^8.11.1",
"node-sass": "^6.0.0",
"postcss": "^8.2.10",
"sass": "^1.37.2",
"sass-loader": "^11.0.0",
"slugify": "^1.4.0",
"tom-select": "^1.7.3",
Expand Down

0 comments on commit 445103f

Please sign in to comment.