feature #5332 Allow to pass no choices no the Choice field (javieregu…

…iluz)

This PR was squashed before being merged into the 4.x branch.

Discussion
----------

Allow to pass no choices no the Choice field

Fixes #3688.

Folks doing advanced things with JS (e.g. dependent lists) might need to add an empty choice field which is populated later.

Commits
-------

6fe5f92 Allow to pass no choices no the Choice field

src/Field/Configurator/ChoiceConfigurator.php

@@ -31,9 +31,6 @@ public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $c
         $isMultipleChoice = $field->getCustomOption(ChoiceField::OPTION_ALLOW_MULTIPLE_CHOICES);
 
         $choices = $this->getChoices($field->getCustomOption(ChoiceField::OPTION_CHOICES), $entityDto, $field);
-        if (empty($choices)) {
-            throw new \InvalidArgumentException(sprintf('The "%s" choice field must define its possible choices using the setChoices() method.', $field->getProperty()));
-        }
 
         if ($areChoicesTranslatable) {
             $field->setFormTypeOptionIfNotSet('choices', array_keys($choices));

tests/Field/ChoiceFieldTest.php

@@ -21,10 +21,8 @@ protected function setUp(): void
 
     public function testFieldWithoutChoices()
     {
-        $this->expectException(\InvalidArgumentException::class);
-
         $field = ChoiceField::new('foo');
-        $this->configure($field);
+        self::assertSame([], $this->configure($field)->getFormTypeOption(ChoiceField::OPTION_CHOICES));
     }
 
     public function testFieldWithChoiceGeneratorCallback()