Skip to content

Commit

Permalink
bug #745 Add missing translation for DELETE button on modal (reypm)
Browse files Browse the repository at this point in the history
This PR was squashed before being merged into the master branch (closes #745).

Discussion
----------

Add missing translation for DELETE button on modal

This add a missing translation to DELETE button as discussed previously with @ogizanagi

Commits
-------

3758945 Add missing translation for DELETE button on modal
  • Loading branch information
javiereguiluz committed Jan 4, 2016
2 parents 96c47db + 3758945 commit 838ffd5
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 1 deletion.
4 changes: 4 additions & 0 deletions Resources/translations/messages.en.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
<source>form.label.empty_value</source>
<target>None</target>
</trans-unit>
<trans-unit id="modal.action.delete">
<source>modal.action.delete</source>
<target>Delete</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions Resources/translations/messages.es.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
<source>form.label.empty_value</source>
<target>Ninguno</target>
</trans-unit>
<trans-unit id="modal.action.delete">
<source>modal.action.delete</source>
<target>Borrar</target>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 4 additions & 0 deletions Resources/translations/messages.fr.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
<source>form.label.empty_value</source>
<target>Aucun(e)</target>
</trans-unit>
<trans-unit id="modal.action.delete">
<source>modal.action.delete</source>
<target>Supprimer</target>
</trans-unit>
</body>
</file>
</xliff>
2 changes: 1 addition & 1 deletion Resources/views/default/includes/delete_form.html.twig
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
{% set _delete_action = easyadmin_get_action(view, 'delete', _entity_config.name) %}
<button type="button" data-dismiss="modal" class="btn btn-danger" id="modal-delete-button">
{% if _delete_action.icon %}<i class="fa fa-{{ _delete_action.icon }}"></i>{% endif %}
{{ _delete_action.label is defined and not _delete_action.label is empty ? _delete_action.label|trans(_trans_parameters) }}
{{ 'modal.action.delete'|trans(_trans_parameters) }}
</button>
{% endif %}
</div>
Expand Down

0 comments on commit 838ffd5

Please sign in to comment.