feature #6132 [BUGFIX] Perform "shouldBeDisplayedFor" check for globa…

…l actions (like "new") (a-r-m-i-n)

This PR was merged into the 4.x branch.

Discussion
----------

[BUGFIX] Perform "shouldBeDisplayedFor" check for global actions (like "new")

Fixes: #6131

Commits
-------

b59d0e0 [BUGFIX] Perform "shouldBeDisplayedFor" check for global actions (like "new")

doc/actions.rst

@@ -149,6 +149,8 @@ to users::
             ->add(Crud::PAGE_INDEX, $viewInvoice);
     }
 
+Note: When using ``displayIf()`` for global actions like "new", no entity instance is passed to closure function.
+
 Disabling Actions
 -----------------
 

src/Dto/ActionDto.php

@@ -239,9 +239,9 @@ public function setTranslationParameters(array $translationParameters): void
         $this->translationParameters = $translationParameters;
     }
 
-    public function shouldBeDisplayedFor(EntityDto $entityDto): bool
+    public function shouldBeDisplayedFor(?EntityDto $entityDto): bool
     {
-        return null === $this->displayCallable || (bool) \call_user_func($this->displayCallable, $entityDto->getInstance());
+        return null === $this->displayCallable || (bool) \call_user_func($this->displayCallable, $entityDto?->getInstance());
     }
 
     public function setDisplayCallable(callable $displayCallable): void

src/Factory/ActionFactory.php

@@ -93,6 +93,10 @@ public function processGlobalActions(?ActionConfigDto $actionsDto = null): Actio
                 continue;
             }
 
+            if (false === $actionDto->shouldBeDisplayedFor(null)) {
+                continue;
+            }
+
             if (Crud::PAGE_INDEX !== $currentPage && $actionDto->isBatchAction()) {
                 throw new \RuntimeException(sprintf('Batch actions can be added only to the "index" page, but the "%s" batch action is defined in the "%s" page.', $actionDto->getName(), $currentPage));
             }