bug #5769 Fix incorrect HTTP status code for form validation errors (…

…asispts)

This PR was merged into the 4.x branch.

Discussion
----------

Fix incorrect HTTP status code for form validation errors

This PR will fix #5768

**Before**

![000](https://github.com/EasyCorp/EasyAdminBundle/assets/79239132/75cc902e-1766-48f2-bfb5-00d4f0cc7036)

**After**

![001](https://github.com/EasyCorp/EasyAdminBundle/assets/79239132/f88999b8-f2f5-42dd-a121-af691c68d1e3)

Commits
-------

712959e Return HTTP 422 on form validation error

src/EventListener/CrudResponseListener.php

@@ -41,12 +41,14 @@ public function onKernelView(ViewEvent $event): void
 
         // to make parameters easier to modify, we pass around FormInterface objects
         // so we must convert those values to FormView before rendering the template
+        $formErrorCount = 0;
         foreach ($templateParameters as $paramName => $paramValue) {
             if ($paramValue instanceof FormInterface) {
                 $templateParameters[$paramName] = $paramValue->createView();
+                $formErrorCount = max($formErrorCount, \count($paramValue->getErrors(true)));
             }
         }
-
-        $event->setResponse(new Response($this->twig->render($templatePath, $templateParameters)));
+        $httpCode = $formErrorCount > 0 ? Response::HTTP_UNPROCESSABLE_ENTITY : Response::HTTP_OK;
+        $event->setResponse(new Response($this->twig->render($templatePath, $templateParameters), $httpCode));
     }
 }

tests/Controller/CategoryCrudControllerTest.php

@@ -64,6 +64,7 @@ public function testNew(?string $invalidCsrfToken, ?string $expectedErrorMessage
             static::assertSelectorNotExists('.global-invalid-feedback');
             static::assertInstanceOf(Category::class, $this->categories->findOneBy(['slug' => 'foo']));
         } else {
+            $this->assertResponseStatusCodeSame(Response::HTTP_UNPROCESSABLE_ENTITY);
             static::assertSelectorTextContains('.global-invalid-feedback', $expectedErrorMessage);
             static::assertNull($this->categories->findOneBy(['slug' => 'foo']));
         }
@@ -105,6 +106,7 @@ public function testEdit(?string $invalidCsrfToken, ?string $expectedErrorMessag
             static::assertSelectorNotExists('.global-invalid-feedback');
             static::assertInstanceOf(Category::class, $this->categories->findOneBy(['slug' => 'bar']));
         } else {
+            $this->assertResponseStatusCodeSame(Response::HTTP_UNPROCESSABLE_ENTITY);
             static::assertSelectorTextContains('.global-invalid-feedback', $expectedErrorMessage);
             static::assertNull($this->categories->findOneBy(['slug' => 'bar']));
         }

tests/TestApplication/src/Entity/Category.php

@@ -5,6 +5,7 @@
 use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\Common\Collections\Collection;
 use Doctrine\ORM\Mapping as ORM;
+use Symfony\Component\Validator\Constraints as Assert;
 
 #[ORM\Entity]
 class Category
@@ -14,6 +15,7 @@ class Category
     #[ORM\Column(type: 'integer')]
     private $id;
 
+    #[Assert\NotBlank]
     #[ORM\Column(type: 'string', length: 255)]
     private $name;