Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #4184 Use "var(--body-bg)" variable for body bg color in Bootstra…
…p (bocharsky-bw) This PR was merged into the 3.0.x-dev branch. Discussion ---------- Use "var(--body-bg)" variable for body bg color in Bootstrap Do you change this file manually or you have a special tool for this? I see this Bootstrap content is not the exact one from the Bootstrap source - it was sligtly modified. Basically, I made this change manually in this PR (the diff on GitHub isn't perfect): ```diff -body{..., background-color:#e3e7ed} +body{..., background-color:var(--body-bg)} ``` The problem is that when you override the `--body-bg` variable in your CSS - you change bg for everything except the body tag :) I suppose it should reuse the `--body-bg` var for body tag as well. This PR should help to override the body bg everywhere by overriding the only `--body-bg` CSS var In other words, when I add this code to my CSS: ```css :root { --body-bg: #dddd44; } ``` It looks like this: <img width="1440" alt="Screenshot 2021-02-04 at 12 34 37" src="https://user-images.githubusercontent.com/3317635/106880737-6603c880-66e5-11eb-8f8e-a553ae66ec20.png"> So to complete the bg change I have to add one more rule: ```css :root { --body-bg: #dddd44; } body { background-color: #dddd44; } ``` That fixes the problem: <img width="1425" alt="Screenshot 2021-02-04 at 12 38 32" src="https://user-images.githubusercontent.com/3317635/106881222-eaeee200-66e5-11eb-9389-967ac56d10a1.png"> But I suppose `--body-bg` change should look like the 2nd screenshot Commits ------- 7d95a63 Use "var(--body-bg)" variable for body bg color in Bootstrap
- Loading branch information