Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glyphicons Halflings reintroduced by mistake #2348

Closed
moynzzz opened this issue Sep 10, 2018 · 4 comments
Closed

Glyphicons Halflings reintroduced by mistake #2348

moynzzz opened this issue Sep 10, 2018 · 4 comments
Labels
bug help wanted Issues and PRs which are looking for volunteers to complete them.

Comments

@moynzzz
Copy link
Contributor

moynzzz commented Sep 10, 2018 •
edited

The files "src/Resources/public/stylesheet/bootstrap.min.css", "src/Resources/public/stylesheet/easyadmin-all.min.css" still contain referenceс to Glyphicons Halflings which were removed in #1533, but later on added when updating front dependencies in #2170.
@javiereguiluz
Copy link
Collaborator

I'm really sorry about this. I'll try to fix it myself in the coming days ... unless someone else wants to fix it themselves. Thanks!

@javiereguiluz javiereguiluz added bug help wanted Issues and PRs which are looking for volunteers to complete them. labels Sep 18, 2018
@moynzzz
Copy link
Contributor Author

moynzzz commented Sep 19, 2018

I can do it myself but I will be really grateful if you can help me because it will be my first PR.

@moynzzz moynzzz mentioned this issue Sep 21, 2018
Merged
javiereguiluz added a commit that referenced this issue Sep 22, 2018
@javiereguiluz
bug #2357 Remove all references for glyphicons in stylesheet files. (…
df61c5b 
…moynzzz)

This PR was merged into the 1.x branch.

Discussion
----------

Remove all references for glyphicons in stylesheet files.

<!--

BUGS must go to '1.x' branch.
NEW FEATURES must go to 'master' branch.

If the NEW FEATURE is complex, open an issue first so we can discuss about it.

Note: all your contributions adhere implicitly to the MIT license

-->
Remove all references for glyphicons in stylesheet files.. Fixes: #2348.

Commits
-------

c92aef3 Remove all references for glyphicons in stylesheet files.
@javiereguiluz
Copy link
Collaborator

Fixed by #2357.

@longnd
Copy link

longnd commented Oct 22, 2018

@javiereguiluz when will the new version of the bundle be released that contains this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted Issues and PRs which are looking for volunteers to complete them.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @longnd @moynzzz