Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default value of the integer option list_max_results is wrongly set to a string #27

Closed
javiereguiluz opened this issue Jan 16, 2015 · 0 comments
Closed

The default value of the integer option list_max_results is wrongly set to a string #27

javiereguiluz opened this issue Jan 16, 2015 · 0 comments
Labels
bug

Comments

@javiereguiluz
Copy link
Collaborator

In DependencyInjection/Configuration.php class, the default value of an integer option is set to a string:

->integerNode('list_max_results')->defaultValue('15')

The string '15' should be the integer 15.

This error was reported by @stof in javiereguiluz@f08250a#commitcomment-9314044
javiereguiluz added a commit that referenced this issue Jan 17, 2015
@javiereguiluz
bug #30 update configuration definition, fixes #27 (xabbuh)
3cb14d2 
This PR was merged into the master branch.

Discussion
----------

update configuration definition, fixes #27

* use an `integer` default value for an `integer` node instead of a
  `string`
* fix a typo

Commits
-------

041f6ff update configuration definition, fixes #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@javiereguiluz