Replace VichUploader trans delete keys #2358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I think we did this on purpose to use the label of our delete action instead of VichUploader label. But does it make sense to do that? So I agree with this change and the new label name is correct, as you can see in https://github.com/dustin10/VichUploaderBundle/blob/master/Resources/translations/VichUploaderBundle.en.yml Thanks @mpiot! |
|
Thanks Mathieu. |
javiereguiluz
added a commit
that referenced
this pull request
Sep 22, 2018
This PR was submitted for the master branch but it was merged into the 1.x branch instead (closes #2358). Discussion ---------- Replace VichUploader trans delete keys It appear a translation key have change in VichUploader. Actually, the vich form use action.delete key, but the correct key is: form.label.delete. Commits ------- 8fbe9fb Replace VichUploader trans keys
|
You're welcome Javier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appear a translation key have change in VichUploader.
Actually, the vich form use action.delete key, but the correct key is: form.label.delete.