Add default field for percent type. Fixes #2208. #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Oct 2, 2018
This PR was merged into the 1.x branch. Discussion ---------- Add default field for percent type. Fixes #2208. This PR adds missing percent field template. This field doesn't depend on format configuration it will use type options if provided to render the value properly. If they aren't provided it will use the defaults of the percent type which are `type = fractional` and `scale = 0`. Commits ------- b1d0a1d Add default field for percent type. Fixes #2208.
|
@moynzzz thanks for adding this missing field template. I made some minor tweaks in the Twig template when merging, but you did it great. By the way, this is probably the last template we're going to add in 1.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing percent field template.
This field doesn't depend on format configuration it will use type options if provided to render the value properly. If they aren't provided it will use the defaults of the percent type which are
type = fractionalandscale = 0.