Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecated] use filter spaceless instead tag #2704

Closed

Conversation

Dev-Int
Copy link

@Dev-Int Dev-Int commented Apr 25, 2019

Since Twig 2.7 tag spaceless is Deprecated use filter instead

@yceruto
Copy link
Collaborator

yceruto commented Apr 25, 2019

We should wait for apply tag instead.
twigphp/Twig#2977

@Dev-Int
Copy link
Author

Dev-Int commented Apr 25, 2019

I think it was since twig/twig:^2.9 ?
I retry with apply tag

edit:
Unexpected "apply" tag (expecting closing tag for the "block" tag defined near line xx)

@xabbuh
Copy link
Collaborator

xabbuh commented Apr 27, 2019

I agree with @yceruto about using the apply tag instead. This will also require to update the version constraint to ^2.9 in the composer.json file (merging should be delayed until there is a stable tag for that version in the Twig repository though).

@Dev-Int
Copy link
Author

Dev-Int commented Apr 27, 2019

What a pity for my first contribution....
Thanks for your help @xabbuh , @yceruto .
I close this PR until @xabbuh suggest:

I agree with @yceruto about using the apply tag instead. This will also require to update the version constraint to ^2.9 in the composer.json file (merging should be delayed until there is a stable tag for that version in the Twig repository though).

@Dev-Int Dev-Int closed this Apr 27, 2019
@xabbuh
Copy link
Collaborator

xabbuh commented Apr 27, 2019

@Dev-Int You can reopen your PR nonetheless and already make these changes. My comment about the merge was more directed to us maintainers to be careful when to press the button. :) I am sorry it that was confusing.

@xabbuh xabbuh reopened this Apr 27, 2019
@Dev-Int
Copy link
Author

Dev-Int commented Apr 27, 2019

Ok @xabbuh . My English is not always on top.
I make the changes... and wait :p

@javiereguiluz javiereguiluz added this to the 2.x milestone Apr 28, 2019
@yceruto
Copy link
Collaborator

yceruto commented May 1, 2019

Twig 2.9 has been released.
I've rebuilt the Travis jobs.
We might need a patch for 1.x as well.

@javiereguiluz
Copy link
Collaborator

Thanks for fixing this deprecation!

javiereguiluz added a commit that referenced this pull request May 25, 2019
This PR was merged into the 1.x branch.

Discussion
----------

Replaced the spaceless tag by the apply tag

This backports #2704 to 1.x branch.

Commits
-------

311456a Replaced the spaceless tag by the apply tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants