Fixed ArrayFilterType issue and add support for multiple => false #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
commented
Jun 21, 2019
| $queryBuilder->andWhere(\sprintf('%s.%s %s', $alias, $property, $data['comparison'])); | ||
| } else { | ||
| $orX = new Expr\Orx(); | ||
| foreach ($data['value'] as $value) { | ||
| $paramName = static::createAlias($property); |
There was a problem hiding this comment.
This is the bug I'm fixing here: each condition must have their own param name.
|
Thanks Yonel for fixing this and adding the tests too. I'll update the docs later because I want to tweak some things for filters. |
javiereguiluz
added a commit
that referenced
this pull request
Jun 21, 2019
… false (yceruto)
This PR was merged into the 2.0.x-dev branch.
Discussion
----------
Fixed ArrayFilterType issue and add support for multiple => false
By default, this filter does not provide any choices list, they are dynamic (tags-style).
Now you can configure your own choices list for array filters:
```yaml
easy_admin:
entities:
Products:
# ...
list:
filters:
- property: 'fieldname'
type: 'array' # use this filter for `array`, `simple_array` and `json_array` types only.
type_options:
value_type_options:
multiple: true # or false
choices: { foo: 'foo', bar: 'bar' }
attr: { data-widget: 'select2' }
```
Commits
-------
562995a Fix ArrayFilterType and add support for multiple => false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, this filter does not provide any choices list, they are dynamic (tags-style).
Now you can configure your own choices list for array filters: