Removed the bootstrap-all files #2787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Jul 6, 2019
This PR was merged into the 2.0.x-dev branch. Discussion ---------- Removed the bootstrap-all files This implements the idea suggested by @alterphp in #2784. The new docs explain it: ``` Loading the Entire Bootstrap Framework -------------------------------------- In EasyAdmin versions prior to 2.2.1, the backend didn't load the entire CSS and JavaScript code from Bootstrap but only the parts that used it. This was made to improve performance and required loading some separate files called ``bootstrap-all.css`` and ``bootstrap-all.js`` when you needed to use some Bootstrap feature not included by default. Given that the performance gain was minimal, this idea was abandoned and, starting from EasyAdmin 2.2.1 the entire Boostrap CSS and JavaScript code is loaded by default in all pages. ``` On my local computer, the compressed size of the entire Bootstrap contents is reasonable: 77KB for JS and 43KB for CSS. Commits ------- 7784d92 Removed the bootstrap-all files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the idea suggested by @alterphp in #2784. The new docs explain it:
On my local computer, the compressed size of the entire Bootstrap contents is reasonable: 77KB for JS and 43KB for CSS.