Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text_editor and code_editor HTML input name #2813

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

yceruto
Copy link
Collaborator

@yceruto yceruto commented Jul 2, 2019

Fixes #2811

For single forms without parent, the variable name is equal to full_name (e.g. description), but for compound forms full_name will contain also the name of the parent form (e.g. product[description]).

@yceruto yceruto changed the title Fix text_edit and code_edit HTML input name Fix text_editor and code_editor HTML input name Jul 2, 2019
@yceruto yceruto added the bug label Jul 2, 2019
@yceruto yceruto added this to the 2.x milestone Jul 2, 2019
@yceruto yceruto mentioned this pull request Jul 2, 2019
@javiereguiluz
Copy link
Collaborator

javiereguiluz commented Jul 3, 2019

Thanks for the bug fix and the explanation!

@javiereguiluz javiereguiluz merged commit 5e8902e into EasyCorp:master Jul 3, 2019
javiereguiluz added a commit that referenced this pull request Jul 3, 2019
This PR was merged into the 2.0.x-dev branch.

Discussion
----------

Fix text_editor and code_editor HTML input name

Fixes #2811

For single forms without parent, the variable `name` is equal to `full_name` (e.g. `description`), but for compound forms `full_name` will contain also the name of the parent form (e.g. `product[description]`).

Commits
-------

5e8902e Fix text_edit and code_edit HTML input name
@yceruto yceruto deleted the fix_2811 branch July 3, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trix text editor
2 participants