New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0] SlugField: don't translate characters & remove special characters #3170

Merged

javiereguiluz merged 1 commit into EasyCorp:master from jmsche:3.0-slugify-improvements

May 2, 2020

Contributor

jmsche commented May 1, 2020

Follow-up of Javier's comment: #3164 (comment)

This PR:

extends (only once) the slugify() function to remove translated symbols (eg. "$" => "dollar")
uses the "lower" option of slugify instead of .toLowerCase()
allows only alphanumeric characters (and dashes) in the slug

Could supersede ec3c8da ?

javiereguiluz added this to the 3.x milestone

Collaborator

javiereguiluz commented May 2, 2020

Very nice improvements 👏 Thanks a lot!


          [3.0] SlugField: don't translate characters & remove special characters

8f8e10c

javiereguiluz force-pushed the 3.0-slugify-improvements branch from 7817296 to 8f8e10c Compare

May 2, 2020 14:02

javiereguiluz merged commit b4e8289 into EasyCorp:master

jmsche deleted the 3.0-slugify-improvements branch

May 13, 2020 11:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment