Fix 435: Display general errors of the form #436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the errors should be shown depending on the property, in your case. But anyway, you're right: showing ALL errors is very important 👍 |
|
@Pierstoval I agree that the error should be attached to the property, I will investigate later on this problem. |
|
@thomasbeaujean thanks for providing this bug fix. I've created in #437 a new PR to add a commit that tweaks the HTML of the form errors. I've reused all your original commits, so you'll get full credit for your work. Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Sep 7, 2015
This PR was merged into the master branch. Discussion ---------- Display the global form errors This finishes #436. Commits ------- e058b8f Tweaked the HTML of the global form errors aaeeb17 The error div must not be display if there is no error 6e5adff Display the general form errors 57a2b77 Merge pull request #5 from javiereguiluz/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
I create an entity that has a one to many relationship.
I have an Assert\Min one this relationship.
When I validate the form, it is not valid but the error is not displayed.