Use the UrlGeneratorInterface instead of the Router implementation #53

javiereguiluz · 2015-01-19T19:29:33Z

This fixes #51

xabbuh · 2015-01-19T19:30:39Z

Twig/EasyAdminTwigExtension.php

@@ -21,7 +21,7 @@ class EasyAdminTwigExtension extends \Twig_Extension

    private $router;

-    public function __construct(Router $router)
+    public function __construct(UrlGeneratorInterface $router)


I would change the variable names as well so that they don't confuse any looking at the code only.

Good idea! I've changed it for $urlGenerator in 78ab378

…ntation (javiereguiluz) This PR was merged into the master branch. Discussion ---------- Use the UrlGeneratorInterface instead of the Router implementation This fixes #51 Commits ------- f5933a8 Use the UrlGeneratorInterface instead of the Router implementation

Use the UrlGeneratorInterface instead of the Router implementation

f5933a8

This fixes #51

javiereguiluz added the feature label Jan 19, 2015

javiereguiluz self-assigned this Jan 19, 2015

xabbuh reviewed Jan 19, 2015
View reviewed changes

javiereguiluz merged commit f5933a8 into master Jan 19, 2015

javiereguiluz deleted the use_interfaces_not_implementations branch January 19, 2015 20:50

javiereguiluz removed feature bug labels Jan 25, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use the UrlGeneratorInterface instead of the Router implementation #53

Use the UrlGeneratorInterface instead of the Router implementation #53

javiereguiluz commented Jan 19, 2015

xabbuh Jan 19, 2015

javiereguiluz Jan 19, 2015

Use the UrlGeneratorInterface instead of the Router implementation #53

Use the UrlGeneratorInterface instead of the Router implementation #53

Conversation

javiereguiluz commented Jan 19, 2015

xabbuh Jan 19, 2015

Choose a reason for hiding this comment

javiereguiluz Jan 19, 2015

Choose a reason for hiding this comment