Added project dependencies in composer #61
Conversation
mmoreram
commented
Jan 20, 2015
mmoreram
commented
- Symfony dependencies (Components and Bundles)
- FrameworkExtraBundle dependencies
| "doctrine/orm" : "~2.3", | ||
| "pagerfanta/pagerfanta" : "~1.0" | ||
| "php" : ">=5.3.0", | ||
| "doctrine/orm" : "~2.3", |
There was a problem hiding this comment.
doctrine/common and doctrine/doctrine-bundle is needed too.
By the way, I would not align the version numbers. It makes the diff mainly useless when only whitespaces change.
There was a problem hiding this comment.
can't find where these packages are required (namespaces? services?)... could you please show us? :)
And the reason of alignment is because preferences of @javiereguiluz, right?
There was a problem hiding this comment.
@mmoreram Never mind, seems that I have to sync my local fork. ;)
There was a problem hiding this comment.
@xabbuh about the alignment, I know that 99% of developers don't agree with me, but I love to align (and sort alphabetically) the dependencies of the projects.
@mmoreram sorry for bothering you, but could you please sort them alphabetically and add one additional white space before all semicolons (:) to turn this:
"sensio/framework-extra-bundle": "~2.3|~3.0",
into this:
"sensio/framework-extra-bundle" : "~2.3|~3.0",
Thanks a lot!
There was a problem hiding this comment.
@xabbuh about the alignment, I know that 99% of developers don't agree with me, but I love to align (and sort alphabetically) the dependencies of the projects.
I forgot about your preferences when commenting. :)
There was a problem hiding this comment.
@javiereguiluz Seriously? ¬¬
There was a problem hiding this comment.
Hehe, sounds a bit psycho but I love doing the same even if I don't do it all the time.
What's again better is to sort the bundles in AppKernel, by FQCN length AND alphabetically.
_Psycho inside_
😉
What's kinda bad is that whenever you make a composer require {package} in the project root directory, the new composer file won't align the packages names and versions.
There was a problem hiding this comment.
Yes, and I am used to sorting the use statements, but not by hand. If you want to ensure that everything is aligned with your style, make sure you provide a mechanism for such, like php-formatter.
There was a problem hiding this comment.
IDEs code formatters can work, especially PhpStorm's one which is very good at it, and fully parametrable
|
@mmoreram thanks for working on this. Should we also add |
|
@javiereguiluz Absolutely. I'll update the branch before lunch! 👍 |
* Symfony dependencies (Components and Bundles) * FrameworkExtraBundle dependencies * Twig library dependency
|
ping @javiereguiluz Updated & Sorted. |
|
👍 |
|
Awesome! @mmoreram thanks for woring on this and for dealing so patiently with my peculiarities ;) |
This PR was merged into the master branch. Discussion ---------- Added project dependencies in composer * Symfony dependencies (Components and Bundles) * FrameworkExtraBundle dependencies Commits ------- d2d0364 Added project dependencies in composer
