Fix ExceptionListener: exception to log isn't necessarily a BaseException instance #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
force-pushed
the
fix_exception_listener_not_a_base_exception
branch
from
9b1044c
to
549c7f8
Compare
|
This seems like a "very edgy edge-case", but still it's better to always do the right thing. Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Dec 27, 2015
…BaseException instance (ogizanagi) This PR was merged into the master branch. Discussion ---------- Fix ExceptionListener: exception to log isn't necessarily a BaseException instance For instance [when an exception occurs when trying to render the exception template](https://github.com/javiereguiluz/EasyAdminBundle/blob/master/EventListener/ExceptionListener.php#L117-L120). Commits ------- 549c7f8 Fix ExceptionListener: exception to log isn't necessarily a BaseException instance
|
@javiereguiluz: As the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance when an exception occurs when trying to render the exception template.