Sync develop into main #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… icon button to modifications
…tion array for badge
… and id-ref matches
OSCALProfile was attempting to preform a React state update on an unmounted component. This indicates a memory leak and caused the tests to have warnings. We added a check to see if a component is mounted before updating state.
OSCALControl was using an index as a key for each OSCALControlPart created. This is advised against by react. The parts being mapped do not have a clear id or field to use as a unique key. Using uuid is the next best way of giving each child element of a list a unique key that persists until the child is recreated.
A few changes were needed to make the code more elegant and readable. Using part.id in OSCALControlPart when possible will also speed up the code.
Due to concern for preformace, index makes more sense to use than generating a uuid for each part.
OSCALMetadata's getPartyRolesText function sometimes would try to use filter() on null values.
EGRC-168 made some very major changes. In order to merge EGRC-412 into develop, they had to be merged. Changes to OSCALLoader & the package-lock files were also needed.
Enable linter
Add contributing and license info to the README
Update README to reflect oscal-viewer & oscal-react-library changes
rgauss
approved these changes
Jul 7, 2021
zclarkEDC
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.