-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Storybook Stories for Metadata, Responsible Roles, and System Components #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkennedy26
changed the title
Create Storybook Stories for Metadata and System Components
Create Storybook Stories for Metadata, Responsible Roles, and System Components
Jul 15, 2021
kkennedy26
requested review from
Bronstrom,
folksgl,
kylelaker,
rgauss,
tuckerzp and
zclarkEDC
July 15, 2021 20:48
Implement variation of System Implementation component where last modification date is displayed.
Implement a variation of the System Implementation component where the the components object does not include props.
Implement a variation of the Metadata component where role of the party is being displayed.
Changed .stories.js files to incorporate all required props in the default and then modularly add optional props with each variation. Added the display of parties to the Metadata story since parties are an optional prop. Altered the System Implementation story to have a variation of the display of the version, a property within components.
Bronstrom
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is coming along nicely!
mikeisen1
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to go and all of the components appear along the screen nicely. Good work!
kylelaker
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added .stories.js files to the components directory
for each component. Component stories were written
in a modular approach with the default story containing
only the required props for the component and
then in each variation of the component optional props were added.
To view the Storybook page, run:
npm install
npm run storybook
in the root directory.