Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Storybook Stories for Metadata, Responsible Roles, and System Components #116

Merged
merged 8 commits into from
Jul 21, 2021

Conversation

kkennedy26
Copy link
Contributor

Added .stories.js files to the components directory
for each component. Component stories were written
in a modular approach with the default story containing
only the required props for the component and
then in each variation of the component optional props were added.

To view the Storybook page, run:
npm install
npm run storybook
in the root directory.

@kkennedy26 kkennedy26 changed the title Create Storybook Stories for Metadata and System Components Create Storybook Stories for Metadata, Responsible Roles, and System Components Jul 15, 2021
Implement variation of System Implementation
component where last modification date
is displayed.
Implement a variation of the System Implementation
component where the the components object
does not include props.
Implement a variation of the Metadata
component where role of the party
is being displayed.
Changed .stories.js files to incorporate all required
props in the default and then modularly add optional
props with each variation.

Added the display of parties to the Metadata story
since parties are an optional prop.

Altered the System Implementation story to have
a variation of the display of the version, a
property within components.
Copy link
Contributor

@Bronstrom Bronstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is coming along nicely!

Copy link
Contributor

@mikeisen1 mikeisen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to go and all of the components appear along the screen nicely. Good work!

@kylelaker kylelaker merged commit 0694952 into EGRC-275 Jul 21, 2021
@kylelaker kylelaker deleted the EGRC-431 branch July 21, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants