Create Test Data Directory #132
Conversation
mikeisen1
requested review from
kkennedy26,
Bronstrom,
zclarkEDC,
folksgl,
hreineck,
kylelaker,
rgauss and
tuckerzp
|
Congratulations on getting your first PR opened in the There are also a few things that I'd like to make sure we get cleaned up in your local git configuration including the Love that we are able to move all this stuff into files that can be referenced from various places and deduplicate a lot of this. While everything here look good at first glance, I am going to hold off on approving until I've had a chance to look a little more closely and we've been able to work together on some of the |
Previously, all of the data was in various files, even duplicated in some instances (across not within files). Added a new directory, test-data, which contains the 7 files where all of the data for testing and the storybook are located. When creating the files, removed the duplications of the data by placing the duplications into one variable. Separated the data by category for ease of finding the data when needed.
|
For the linting errors, I believe that @hreineck has had a similar issue in the past. I think the fix was to make sure you update and commit |
Co-authored-by: Henry Reineck <43356777+hreineck@users.noreply.github.com>
Co-authored-by: Henry Reineck <43356777+hreineck@users.noreply.github.com>
|
I committed the changes suggested by @hreineck and updated the package-lock.json, but I am still getting the issues of failing the linter check. |
Try |
|
Actually, looks like it's complaining about example/package-lock.json as well. Maybe try committing the changes to that too. |
I am surprised that fff7cb9 doesn't fix that. |
In the code checks for the pull request, there is a linting error regarding the package-lock JSON files. It states that local changes to those files would be overwritten by a checkout and the changes must be committed. The package-lock JSON files were updated and committed to resolve the linting errors.
|
For the lint checks, I was initially having an issue of not being able to checkout another branch even locally. I fixed that issue, ran the npm install command in both directories, and double-checked that the git checkout to another branch would work. That is now working locally but the lint check is still failing. Does anyone have advice on how I can resolve this? The error message presented when I was not able to locally check out was the exact same as the lint check error message. |
Updating package-lock.json and example/package-lock.json to sync them up with the remote branch. This should fix the failures in the linting actions.
Update four test files to resolve the linting errors from the code check of the previous commit.
Modified test files which improperly imported the default functions, causing the lint check and testing to fail.
Modify two test files to resolve prettier/prettier style errors, in order to pass the lint check.
Modify two test files to conform with the linter style requirements, in order to pass the lint check.
|
@mikeisen1 now that we've merged all the other stuff into EGRC-275, can you take one more look at everything to make sure all the data is organized correctly? I think #116 may have added more stuff |
Move data over from 4 additional stories that were added, satisfying the requirement of having all test and storybook data in one directory. This makes it easier to use data across tests and stories, as well as view the actual data used.
Updating package-lock.json and example/package-lock.json to sync them up with the remote branch. This should resolve the linting errors.
Committing changes to package-lock files in order to fix the failing linter checks.
Finished subtask EGRC-469 where I migrated the data into one directory and updated test
and storybook file imports as necessary.