Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display SSP Authz Boundary #255

Merged
merged 8 commits into from
Feb 16, 2022
Merged

Conversation

rgauss
Copy link
Contributor

@rgauss rgauss commented Feb 15, 2022

Closes #225

Recreation of #253

If looking to do manual testing of this you can run the app in REST mode with pointing to a service with changes in EasyDynamics/oscal-rest-service#49

@rgauss rgauss requested a review from a team February 15, 2022 01:13
@rgauss
Copy link
Contributor Author

rgauss commented Feb 15, 2022

Rename OSCALDIagram.test.js to OSCALDiagram.test.js

I did that locally but somehow it was not included in the commit so had to do it via GitHub UI.

@kylelaker
Copy link
Contributor

Rename OSCALDIagram.test.js to OSCALDiagram.test.js

I did that locally but somehow it was not included in the commit so had to do it via GitHub UI.

Oh yeah, fixes like this get weird on case-insensitive filesystems like APFS if you do mv fIlE file && git add . && git commit -- instead, git usually does better with it if you git mv fIlE file && git commit.

Copy link
Contributor

@kylelaker kylelaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to test this but I do have an early question based on a just-reading-the-code review.

@kylelaker
Copy link
Contributor

image
Good stuff!

@hreineck hreineck self-requested a review February 16, 2022 23:23
Copy link
Contributor

@hreineck hreineck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Image displays and looks nice locally, and all tests pass.

@kylelaker kylelaker merged commit b1530e8 into develop Feb 16, 2022
@rgauss rgauss deleted the feature/display-ssp-authz-boundary branch February 28, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display SSP Authorization Boundary
3 participants