Ensure errors are caught and resettable #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylelaker
force-pushed
the
feature/error-boundaries-again
branch
2 times, most recently
from
e4fd27d
to
b6693a0
Compare
We have continued to have some issues with errors that occur during the
OSCALLoader (and OSCALLoaderForm) because of the structure of various
components and where the errors occur. This implements a quick fix to
push the errors down into a child component of OSCALLoader. That
component will then throw the error, which can be caught be the
ErrorBoundary because it occurs as a child of the ErrorBoundary. This
should continue to preserve the form and other UI elements.
This has some kinda nasty side effects. The error message in the console
will sorta mask the actual location where the error occurred (it will
look like it came from the `ErrorThrower`) unless the error itself got
logged before that (which seems to usually happen) or unless the error
actually occurs somewhere in `{result}` which we've handled pretty
correctly for the most part.
`ErrorThrower` is deprecated upon creation because wow I really don't
want to see this in other places in our code base.
kylelaker
force-pushed
the
feature/error-boundaries-again
branch
from
b6693a0
to
4fc469e
Compare
tuckerzp
approved these changes
Jul 11, 2022
Bronstrom
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
This works well! Don't see any more problems with this error when testing both the viewer and editor.
I'll admit, I'm not a huge fan of having a deprecated method, but it seems like this is one of the better options for handling the problem right now. I think the issues with state and components interacting with OSCALLoader have become more and more relevant, and I think it would make sense we try to restructure these in the near future.
tuckerzp
added a commit
to EasyDynamics/oscal-editor-deployment
that referenced
this pull request
Jul 14, 2022
This tests changes introduced by EasyDynamics/oscal-react-library#490
tuckerzp
added a commit
to EasyDynamics/oscal-editor-deployment
that referenced
this pull request
Jul 25, 2022
This tests changes introduced by EasyDynamics/oscal-react-library#490
kylelaker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have continued to have some issues with errors that occur during the
OSCALLoader (and OSCALLoaderForm) because of the structure of various
components and where the errors occur. This implements a quick fix to
push the errors down into a child component of OSCALLoader. That
component will then throw the error, which can be caught be the
ErrorBoundary because it occurs as a child of the ErrorBoundary. This
should continue to preserve the form and other UI elements.
This has some kinda nasty side effects. The error message in the console
will sorta mask the actual location where the error occurred (it will
look like it came from the
ErrorThrower) unless the error itself gotlogged before that (which seems to usually happen) or unless the error
actually occurs somewhere in
{result}which we've handled prettycorrectly for the most part.
ErrorThroweris deprecated upon creation because wow I really don'twant to see this in other places in our code base.
Closes #489