Fix double-trigger of reload in OSCALLoaderForm #491
Conversation
Currently, the `onUrlChange()` is fired whenever any character is typed. This is sorta undesirable because it can result in various re-rendering happening in a few places prematurely. As-is, this doesn't work. It seems like the actual value received by `OSCALLoader` "lags" behind the input value by one form submission.
kylelaker
force-pushed
the
feature/make-form-behave-predictably
branch
from
5943cb9
to
822aab6
Compare
With 490 merged, I believe this can be addressed. I'm glad that were handling this now! I noticed a major slowdown here too when adjusting the form URL, and was thinking it was related to the |
|
It looks like the |
The State was not being updated quickly enough before reloading the document. This led to it seeming like the Viewer was lagging behind by one each time you hit `Reload`. Instead, the `LoaderForm` merely handles changing the current oscalUrl and the Loader reloadings upon that change.
|
I will wait for @kylelaker to review my change and take it out of draft, but I think this should be fixed. There was a weird issue where we were reloading before the state had a change to actually update. |
|
Thanks for helping with this @tuckerzp. I approve of the changes you've made here; I think you should feel free to mark this PR as approved as well (if you do approve). |
kylelaker
changed the title
Currently, the
onUrlChange()is fired whenever any character is typed.This is sorta undesirable because it can result in various re-rendering
happening in a few places prematurely.
As-is, this doesn't work. It seems like the actual value received by
OSCALLoader"lags" behind the input value by one form submission.Relies on #490