Fix alias domains #341
Merged
Fix alias domains #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>
mrrobot47
requested changes
Aug 3, 2020
There was a problem hiding this comment.
Things to be checked:
-
Warning: Loading of domain certificate failed -
PHP Recoverable fatal error: Object of class AcmePhp\Ssl\Certificate could not be converted to string in /root/workspace/easyengine/vendor/easyengine/site-command/src/helper/Site_Letsencrypt.php on line 305 - Wildcard cert getting issued for main site as well if other alias has wildcard.
Fixed following: 1. Warning: Loading of domain certificate failed 2. PHP Recoverable fatal error: Object of class AcmePhp\Ssl\Certificate could not be converted to string in /root/workspace/easyengine/vendor/easyengine/site-command/src/helper/Site_Letsencrypt.php on line 305 2. Wildcard cert getting issued for main site as well if other alias has wildcard.
mrrobot47
requested changes
Aug 5, 2020
mrrobot47
requested changes
Aug 5, 2020
Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>
mrrobot47
requested changes
Aug 6, 2020
Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>
mrrobot47
added a commit
to mrrobot47/site-command
that referenced
this pull request
Aug 19, 2020
Signed-off-by: Riddhesh Sanghvi <riddhesh237@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also reverts #335
Related: EasyEngine/site-type-wp#168
Closes EasyEngine/feature-requests#23