[WIP]Add alias flag for alias-name support in wp #149
Conversation
sagarnasit
changed the title
| @@ -510,6 +517,16 @@ private function configure_site_files() { | |||
| $custom_conf_source = SITE_WP_TEMPLATE_ROOT . '/config/nginx/user.conf.mustache'; | |||
| $process_user = posix_getpwuid( posix_geteuid() ); | |||
|
|
|||
| if ( ! empty( $this->site_data['site_aliases'] ) ) { | |||
|
|
|||
| $domains = explode( ',', $this->site_data['site_aliases'] ); | |||
There was a problem hiding this comment.
explode only if ( 'subdom' === $this->site_data['app_sub_type'] ), otherwise directly use the input. No need for extra processing of exploding and then rejoining for no reason in other WordPress site types.
|
Nice!! Can we please ensure this works with multiple Letsencrypt wildcards, e.g. ☝️ this should hopefully register a wildcard letsencrypt cert with all 3 on it: Cannot wait to try this out! Thanks!!! |
|
Closing this PR as alias domain support has already been added in 4.1. However, it only worked on Further updates will be posted on EasyEngine/feature-requests#23 |
closes: EasyEngine/feature-requests#23
Depends on:
EasyEngine/site-command#296