Default IEasyNetQLogger performances

[mleenhardt]

Looking at this thread, it looks like the default IEasyNetQLogger ConsoleLogger can be a bottleneck.

I'm guessing people may not pay attention to the fact that a custom implementation can be specified and will just often stick with the default.

Looking at the current implementation, I think it could use some improvements like:

• Queue all write in a concurrent collection and Console.WriteLine from a background thread.
• Define additional *Write methods that take one, two and three object parameters (the same way String.Format and Console.WriteLine do) to avoid the slight overhead of using params object[] when we don't have to.
• ...

[Pliner]

@mleenhardt

1. In my opinion, we shouldn't tune logging because where are a lot of libraries that do it nice. I think turning off logging by default(use NoopLogger) or just stay as is are reasonable options.
2. Sounds very good.
3. Should we create separare packages for log4net and nlog to implement IEasyNetQLogger properly?

@mikehadlow @micdenny what do you think?

[mleenhardt]

I didn't consider it but disabling logging by default and letting it be 'opt-in' indeed sounds like a good option. A bunch of framework do it that way, e.g. EF where you specify an Action<string> to enable logging.

I agree that there are already a bunch of great logging frameworks out there, we probably shouldn't be reinventing the wheel.

[mikehadlow]

I'm happy to have no logging by default out-of-the-box. We already
encourage people to replace the console logger with something better suited.

On Mon, Feb 23, 2015 at 8:51 AM, Mathieu Leenhardt <notifications@github.com

wrote:

I didn't consider it but disabling logging by default and letting it be
'opt-in' indeed sounds like a good option. A bunch of framework do it that
way, e.g. EF where you specify an Action to enable logging.

I agree that there are already a bunch of great logging frameworks out
there, we probably shouldn't be reinventing the wheel.

—
Reply to this email directly or view it on GitHub
#385 (comment).

[Pliner]

@mikehadlow What do you think about creating nuget packages for log4net and nlog?
For example, in topshelf it's very easy to start logging using log4net: install nuget package and register new logger via simple UseLog4Net call on host configuration. In our case every user has to implement IEasyNetQLogger interface.

[mikehadlow]

I think that'd be a great idea.

[Pliner]

@mikehadlow nice. will do pull request soon :)

[mleenhardt]

The no logging by default part was done in #391.

I also need to update the wiki page accordingly.

[mleenhardt]

Wiki updated.