Cleanup unused tools #1078
Merged
Cleanup unused tools #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zidad
approved these changes
Jun 16, 2020
Pliner
added a commit
that referenced
this pull request
Nov 1, 2020
* Remove class constraint (#852) * Async first API (#820) Async first API * Use Abstractions for Microsoft DI (#855) * Use Abstractions for Microsoft DI Using the Abstractions doesn't force users to use a particular implementation version of Microsoft's DI. This is how it's done in other libraries as well, including Microsoft's projects. Examples: https://github.com/aspnet/Caching/blob/master/src/Microsoft.Extensions.Caching.Memory/Microsoft.Extensions.Caching.Memory.csproj https://github.com/HangfireIO/Hangfire/blob/master/src/Hangfire.AspNetCore/project.json * Added implementation to unit test project. Had to use version 1.1.1 since test framework targets .Net 4.5.2 * Move preprocessor directives to TaskHelpers for better readability (#860) * changed DefaultConsumerErrorStrategy members to protected for extensibility (#870) * Delete sync Wait (#873) * LibLog - Fixed NLog + Log4net callsite. Added support for NLog structured logging (#876) * Updated LibLog to version 5.0.3 and improved NetStandard2-dependencies (#877) * Created ConsumerCancelled event on ConsumerCancellation class to be fired when a consumer has been canced by the broker * Removed hardcoded connection to rabbit (#885) * Fix MessageVersionStack to work with more than 2 versions (#899) MessageVersionStack was working strangely when there were more than two versions of a message. If you have three versions of a message, i.e. MyMessage, MyMessageV2 and MyMessageV3, you've got a subscriber for each of them, and publish MyMessageV3, only MyMessageV3 and MyMessage are received, MyMessageV2 never arrives. The root of the problem was traced into how versioned exchanges are declared and bound to each other. The exchange for MyMessageV3 is bound to the relevant queues and into the exchange of MyMessage, but not into the exchange of MyMessageV2, which it should do as well. The reason for this was in MessageVersionStack.GetSupersededType, which takes a message type and all the ISupersede interfaces that the message implements, and returns the first in the list (if there are multiple levels of versions it should return the last). The fix was to change GetSupersededType to always return the last element in the list, after which it works with an arbitrary number of message versions. * Make GetSupersededType work with any message version hierarchy (#902) MessageVersionStack.GetSupersededType uses Type.GetInterfaces which does not offer any order guarantees. When selecting the superseded type for a message, we could sort by class name, but that would just introduce a limitation on message naming. Instead of that, let's call GetInterfaces for type and type.BaseType, and grab the ISupersede entries from those. The one that does not exist in base type's list is the correct superseded type. * Revert "Created ConsumerCancelled event on ConsumerCancellation class to be fired when a consumer has been canced by the broker" (#912) This reverts commit d30c051 (cherry picked from commit 487a4db) * Fix merge * Rewrite RPC with async API (#861) * Migrate Rpc to async API * Fix tests * Fix tests * Fix tests * Move RegisterResponseActions before DeRegisterResponseActions * Fix tests * Fix test * Bump LangVersion to latest (#913) * Migrate SendReceive to async API (#914) * Simplify usage of ConcurrentDictionary (#917) * moved extensions methods under the same namespace as IBus to help developers easily discover all the public interface (#918) * fix extension methods that were missing the this keyword 😄 (#919) * added comments on AwaitableDisposable to clear out the purpose of that structure [skip ci] (#922) * Rework queue declaration. LazyQueue is introduced. (#921) * Rework queue declaration. LazyQueue is introduced. * Fix tests * Fix tests * Fix tests * Missing method description was added as well as sync extension * Move caching of declared exchanges to AsyncCache (#925) * Tests for #926 * Rework exchange declaration (#924) * Exchange queue declaration * Fix tests * Documentation was added * Queue and exchange declaration rework (#931) * Queue and Exchange hold parameters of their declaration * Queue and Exchange hold parameters of their declaration * Queue and Exchange docs * Fix tests * Fix tests * Move rabbitmq extensions to extensions method * Drop strange test of Microsoft DI * Drop waffle badges * Fix typos (#949) * Fix #947 (#948) * Code cleanup (#950) * whitespaces * inline variable declaration * whitespaces * pattern matching * throw expressions + default * whitespaces * more * Make EasyNetQ exceptions really serializable Fixes #705 (#953) * Use rabbitmq client automatic reconnection (#794) * merge from master (#982) * merge from master to develop * Fix #978 (#979) * Fix #978: LegacyTypeNameDeserializer now tries resolve types without their assembly name (fixes interoperability issue for generic type parameters between .NET Core and .NET Framework) * Add option to subscribe to lazy queues. (#993) * Add option to subscribe to lazy queues. * Add tests for subscription with queue mode. * Added unit tests and publisher confirm to DefaultConsumerErrorStrategy (#997) * Added unit tests and publisher confirm to DefaultConsumerErrorStrategy * fix package references * fix package references * update build.bat to use visual studio 2019 * Fix publisher confirmation bug (#1008) Fix bug where publisher confirms times out because model object reference has been changed * Add .Net Version to ClientProperties (#1025) * Fix RPC when using legacy conventions (#1040) * Connection implements IAutorecoveringConnection instead of IRecovery (#1045) * Connection implements IAutorecoveringConnection instead of IRecovery * Yet another commit to run CI * Fix tests * Fix tests * Fix typo in logs * Add more editorconfig rules (#1026) * add more editorconfig rules, add solution items * Update .editorconfig * Apply code style rules (#951) * nameof * add stylecop analyzer * remove and sort usings * more * use builtin type alias * ignore rules * documentation reordering, fix parameters * whitespaces * documentation fixes * spaces instead of tabs * whitespaces * remove multiple blank lines * more whitespaces * more spaces * Braces for multi-line statements should not share line * remove empty lines * pattern matching * rules for docs * access modifiers + auto properties * access modifiers * more spaces * remove trailing spaces * access modifiers * access modifiers and line separations * readonly modifier * disable analyzer by default * one more fixes * cosmetics * Remove PublishConfiguration.QueueName (#1051) (cherry picked from commit cc581de) * Fix build * Fix IScheduler implementations: topic should not be null * Fix tests * Add missing ConfirmSelect (#1058) * Add missing ConfirmSelect * Add more tests * Manage timeouts with CancellationToken and respect CancellationToken as possible (#1056) * Manage timeouts with CancellationToken * Rename * Small fixes * Update Source/EasyNetQ/Internals/TaskHelpers.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru> * Update Source/EasyNetQ/Producer/DefaultPubSub.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru> * Update Source/EasyNetQ/Producer/DefaultPubSub.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru> * Add more cancellation tokens * Rework ClientCommandDispatcher 1. Replace dispatching actions using a thread with dispatching actions under a lock, which simplifies code gracefully and allow to pass CancellationToken. 2. IClientCommandDispatcher now has only `Task<T> InvokeAsync<T>(Func<IModel, T> , CancellationToken)`. 3. PersistentChannel becomes asynchronous as well. * Fix tests * Switch requestedHeartbeat from ushort to Timestamp * Fix tests * Renames * Interrupt pending confirmation only for recreated ChannelNumber * Renames * Agreed to leave internals public but with a warning * Allow to specify timeout as -1, drop unused dispatcherQueueSize * Fix port in logs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru> * Manage timeouts in tests * MultiChannelClientCommandDispatcher (#1059) * A draft of MultiChannelClientCommandDispatcher * Fix tests * Fix bug * Minor fixes * Cleanup code * Add tests, fix tests * Add xml docs * Add xml docs * Optimize AsyncLock a bit * Add tests and fix xml docs * Add more tests * Fix AsyncQueue bugs * Bump framework * Update Source/EasyNetQ/Internals/TaskHelpers.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru> * Update Source/EasyNetQ/Internals/TaskHelpers.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru> * Update Source/EasyNetQ/ServiceRegisterExtensions.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru> * Update Source/EasyNetQ/Internals/AsyncQueue.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru> * Review comments * :-/ * Update Source/EasyNetQ/Internals/AsyncQueue.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru> * Fix targets * Fix review comments, cleanup Co-authored-by: Ivan Maximov <sungam3r@yandex.ru> * Drop UseBackgroundThreads (#1061) * Drop UseBackgroundThreads * Reformat * Fix tests * Missing RunContinuationsAsynchronously * Fix client name and clean up configuration (#1062) * Fix name and clean up configuration * Set ContinuationTimeout to Timeout * Fix tests * Fix tests * Update Source/EasyNetQ/ConnectionConfiguration.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru> Co-authored-by: Ivan Maximov <sungam3r@yandex.ru> * Create a channel per operation type and handle soft failures (#1063) * Split operations to multiple channels * Fix tests * Fix tests * Fix tests * Fix tests * Fix tests * Add xml docs * Increase initialization timeout * Fix bug * Add more soft failures codes * Fix EventArgs * Move extensions * Drop handwritten parsing of AMQP Error * Increase timeout * Move connection to channel factory constructor instead of Create method * Add tests and fix request pipelining forbidden exception * Increase test timeout, decrease fixture timeout * Remove retry support * Drop ports * Fix review comments * Fix "The key already existed in the dictionary" * Move extensions * Add more information about exception * Fix lock * Add tests * Move logging from HandlerRunner to DefaultConsumerErrorStrategy (#1069) * Improve connection events (#1070) * PersistentConnection connects lazily to allow to receive a connection event * Do not copy subscriptions for iteration and catch handlers errors * Add docs * Fix tests * Add more docs * Cleanup tests * Split ConnectionConnectedEvent to two events * Fix test * Clean up tests and rename Connected to Created * Add integration test regarding connected event * Delete legacy integration tests (#1072) * Extract IPubSub, IRpc, ISendReceive, IScheduler to root namespace (#1074) * Move PubSub from Producer namespace * Move SendReceive from Producer namespace * Move Rpc from Producer namespace * Internalize ConnectionStringGrammar * Move Schedulers from Scheduler namespace * Internalize *Configuration and add docs * Improve mandatory flag support in case of enabled publisher confirms (#1077) * Throw MessageReturnedException if a message is returned * Renames * Renames * Add more tests * Renames, add more docs * Enable strong naming (#1075) * Enable strong naming * Delete crap * Add PublicSign condition * Fix assembly name * Fix assembly name * Enable strong naming as much as possible except LightInject and StructureMap * Priority support (#1076) * A first step of priority support implementation * Fix tests * Fix response configuration * Pulling consumer (#1073) * A first attempt to implement pulling consumer * Allow to pull messages in batch, ack and reject them in batch as well * Fix typo * Fix typo * Add PullingConsumer<T> * Add remained messages count * Cleanup unused tools (#1078) * Cleanup unused tools * Do not build twice * Add xml docs (#1081) * Add xml docs * Add xml docs * Fix Argument exception is thrown on dispose of consumer dispatcher (#1096) * Various fixes (#1128) * Fix review suggestions for PullingConsumer * MessageReceivedInfo is readonly, xml docs * Fix review comments regarding PullingConsumer * Add xml docs * Add xml docs * Hosepipe. Enable publish confirms, improve connection management (#1131) * Allow Nack from consumer (#1132) * Introduce MessageHandler, IMessageHandler, IMessageHandler<T> * Return AckStrategy from message handler * Add tests * Missing overloads * Parameterize RpcReturnQueueNamingConvention by response type (#1134) * Parameterize RpcReturnQueueNamingConvention by response type * Small renames * Do not allow change conventions via interfface * Add xml docs * Add basic quorum queue support (#1136) * Add basic quorum queue support * Fixes * Fix review suggestion * Trigger CI * Basic support of Single Active Consumer (#1138) * Basic support of Single Active Consumer * Rename Info to ReceivedInfo * Move several methods from IAdvancedBus to extensions * Drop ConsumerCancellation * Fix * Fix tests Co-authored-by: Shannon V.C <286005+staples17@users.noreply.github.com> Co-authored-by: justmara <justmara@users.noreply.github.com> Co-authored-by: Rolf Kristensen <snakefoot@users.noreply.github.com> Co-authored-by: rtaylor01 <36667928+rtaylor01@users.noreply.github.com> Co-authored-by: diasksu <r245tm@yandex.ru> Co-authored-by: Topi Santakivi <topi.santakivi@gmail.com> Co-authored-by: Michael Denny <micdenny@gmail.com> Co-authored-by: Ivan Maximov <sungam3r@yandex.ru> Co-authored-by: Wiebe Tijsma <wiebe@tijsma.com> Co-authored-by: zhangkun <51398532+ZK-Andy@users.noreply.github.com> Co-authored-by: Faisal Abbas <faisal.abbas@elastica.co> Co-authored-by: René Rotvig Jensen <renerotvig@msn.com> Co-authored-by: Leszek <leszek.pietrzak@gmail.com> Co-authored-by: Simonas <simluk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:-/