Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add missing GenerateForm function #469

Merged
merged 3 commits into from
May 11, 2023
Merged

[chore] Add missing GenerateForm function #469

merged 3 commits into from
May 11, 2023

Conversation

nwithan8
Copy link
Member

Description

The GenerateForm function has been missing in the .NET library since at least v4, likely accidentally got removed during the thread-safe re-architecture. This PR reintroduces it and unit tests

Testing

  • Add unit tests for GenerateForm function, new cassettes
  • Add assertion utility to confirm nothing in enumerable matches

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

- Add unit tests for GenerateForm function
- Add assertion utility to confirm nothing in enumerable matches
@nwithan8 nwithan8 requested a review from a team May 11, 2023 19:56
- Docstrings
- Changelog entry
@nwithan8 nwithan8 merged commit 44a344e into master May 11, 2023
@nwithan8 nwithan8 deleted the forms branch May 11, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants