Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep never wears off in OFF #1276

Closed
rsclifford opened this Issue Oct 7, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@rsclifford
Copy link

rsclifford commented Oct 7, 2017

Name of the game:

OFF (v1.6.1, English 2.0 Update)

Player platform:

Windows

Attach files (as a .zip archive or link them)

easyrpg_log.txt
Save01.zip

Describe the issue in detail and how to reproduce it:

The first boss, Dedan, can inflict the Asleep ailment with his "Hour Hand" attack. It's supposed to wear off after a while, but it never does.

To reproduce:

  • Load the attached save
  • Walk forward, choose "Yes" when asked if you want to go through the gate, and go through the conversation
  • Wait for Dedan to connect with "Hour Hand" and put a party member to sleep
@carstene1ns

This comment has been minimized.

Copy link
Member

carstene1ns commented Oct 8, 2017

Hello, thanks for the bug report!
This is simply not implemented yet (even if #821 says otherwise, I could not find it in the code).

For reference: In OFF "Asleep" state lasts for 1 turn, then chance of recovery is ¼, when hit ½.

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Oct 8, 2017

Not sure ifn"when hit" is impemented. Heal after x turns is https://github.com/EasyRPG/Player/blob/master/src/game_battler.cpp#L621

@carstene1ns

This comment has been minimized.

Copy link
Member

carstene1ns commented Oct 8, 2017

Whoops, did look at battle_algorithm only 😀.
However, even when playtesting, it did not wear off. Will play around with this a bit.

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Dec 5, 2017

This is indeed broken because the state heal is only processed when the actor does a turn which is impossible when sleeping.
Besides this bug the turn count is handled incorrectly for state heal: Currently is only incremented when the actor has a turn instead of when any actor/enemy does a turn.

@carstene1ns

This comment has been minimized.

Copy link
Member

carstene1ns commented Nov 7, 2018

(needs testing after all these battle fixes)

@fdelapena

This comment has been minimized.

Copy link
Contributor

fdelapena commented Jan 12, 2019

Tested with current master, this issue still happens, apparently.

@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Feb 7, 2019

will see if this is still an issue and provide a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.