New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle System: Remaining, not implemented stuff #821

Open
Ghabry opened this Issue Mar 15, 2016 · 14 comments

Comments

Projects
None yet
7 participants
@Ghabry
Copy link
Member

Ghabry commented Mar 15, 2016

This is a meta bug to track the remaining battle stuff that is not implemented.
When fixing bugs please reference #821 in your pull request :)

  • Battle Action: Defend command: Not working at all in 2003, not sure about 2000. (Animation is wrong in 2003 but this only visual)
  • Actor: Dual Wield: "Equip Weapon with both hands". When doing a normal attack the attack animations of both weapons will play and the damage is the sum of both. Also needs testing if the Equipment Scene handles this since 0.6
  • Actor: Mighty Guard: "The effect of the [Defend] command will be doubled, further reducing received damage."
  • Actor: Element Guard: Multiplier for damage receiving
  • Skills: Ignore defense: "the specified stat will be reduced without applying the opponent's defence."
  • Skills: States. The 2nd non-default option (Heal instead of Inflict) is not handled.
  • Skills: Attack Element is not respected
  • Skills: Reduce Resistance "If enabled, the resistance to the checked types in (14) of the target characters will decrease or increase by 1 stage." (so from C to D, or C to B)
  • Skills: MP cost based on percentage
  • Items: Two handed (needs changes to Equipment scene?) since 0.6
  • Items: MP cost (What is this? You can use Items as skills, maybe they mean this)
  • Items: Critical rate: We only handle the actor critical rate
  • Items: Effect: Preemptive Advantage during battle "Ignores agility and attacks at the beginning of the turn." Partly, not for 2k full since 0.6
  • Items: Effect: Attack twice at the same time " Each normal attack hits the enemy twice." since 0.6
  • Items: Effect: Attack all enemies at the same time "Each normal attack hits the entire troop."
  • Items: Effect: Ignore enemy dodge rate "Attack accuracy ignores the enemy's agility." since 0.6
  • Items: Effect: Player can't unequip. The equipment cannot be removed. (Needs a change to the Equipment scene)
  • Items: Attack element
  • Items: State handling: needs tests
  • Items (Weapons): The 2nd option (heal instead of inflict) for states since 0.6
  • Items (Other): The 2nd option (heal instead of inflict) for states
  • Items: State Infliction % (is that handled???)
  • Items: Prevent Critical Hits "Enemy characters will not critically hit the wearer". since 0.6
  • Items: Increase dodge rate for physical attacks "Normal attacks dealt by enemy characters will miss more often."
  • Items: Half MP Cost " The MP cost required for skills will be halved."
  • Items: Negate Terrain damage "Damage from terrain will not be taken." since 0.6
  • Items: Player can't unequip "The equipment cannot be removed." - Equipment scene since 0.6
  • Enemies: [Normal Attacks Miss] "the accuracy level of the enemy character's normal attacks is reduced to 70% instead of the usual 90%. This does not affect other moves like skills."
  • Enemies: Elemental Rate
  • States: Accuracy modifier since 0.6
  • States: Recover when Hit X% Chance of Recovery
  • States: 100% Dodge "In battle, for as long as this state is active, opponent attacks will not hit (except for skills)." since 0.6
  • States: Reflect Magic "In battle, for as long as this state is active, skills used by the opponent will be reflected and deal damage to the user instead."
  • States: Fixed Equipment "For as long as this state is active, weapons and equipment cannot be changed." - Needs change to equipment scene since 0.6
  • States: Actor Status (Double and Halved)
  • [x] System2: Flip assets if facing the other direction "Not documented in the help file m(" Moved to #1564

actor

elements

enemies

items

shield

skills

states

@Ghabry Ghabry added this to the 0.6.0 milestone Mar 15, 2016

@Tondorian

This comment has been minimized.

Copy link
Member

Tondorian commented Mar 15, 2016

Enemies: [Normal Attacks Miss] "the accuracy level of the enemy character's normal attacks is reduced to 70% instead of the usual 90%. This does not affect other moves like skills."

is allready handled in master
game_battlealgorithm.cpp line 474

and game_enemy.cpp line 162

@Tondorian Tondorian referenced this issue Mar 17, 2016

Merged

BattleFixes #826

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Jun 14, 2016

The following will be fixed by #905

"Items: Effect: Preemptive Advantage during battle "Ignores agility and attacks at the beginning of the turn."

"Items: Half MP Cost " The MP cost required for skills will be halved."

@fdelapena

This comment has been minimized.

Copy link
Contributor

fdelapena commented Jul 11, 2016

Is the "enable combo" feature in this list? several games show around 5 warnings per second with this one. Fixed, thanks!

@MudarraP

This comment has been minimized.

Copy link

MudarraP commented Jul 27, 2016

Not sure if this one has been taken into account in the current list, I'll try to explain in detail.
There are items which can be selected as "Special" type and can be attached to skills. In the example image, the skill "Rompe-Barrera" decreases the enemy defense (which in the beginning of the battle was increased with another skill). In easyRPG using the item does nothing (the usage message is shown, and that's all), so the battle remains impossible, because the enemy can get his defense stronger with his skill, but you can't decrease his defense using the item.

REVIEW: The item not decrease the value of defense, but the different types of defense (sword, fire, water, wind, etc.)

mdo-item

@carstene1ns

This comment has been minimized.

Copy link
Member

carstene1ns commented Jan 8, 2017

System2: Flip assets if facing the other direction "Not documented in the help file m("

if I remember correctly, this affects Pom gets WI-FI, in RPG_RT they turn around:
flip

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Jan 21, 2017

"Skills: States. The 2nd non-default option (Heal instead of Inflict) is not handled." breaks the skill Zwiestrich in Wolfenhain.

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Aug 13, 2017

Not worth opening an extra issue: "Change Battle Commands"
"if there are already 6 battle commands, the command to [Add] will be ignored."

@Albeleon

This comment has been minimized.

Copy link
Member

Albeleon commented Jul 7, 2018

#1373 The number after each issue refers to each commit inside this PR
"Actor: Dual Wield: "Equip Weapon with both hands". When doing a normal attack the attack animations of both weapons will play and the damage is the sum of both. Also needs testing if the Equipment Scene handles this"
3.19: Implemented in 2k battles. Needs testing in 2k3 battles and the Equipment Scene.

"Items: Effect: Attack twice at the same time " Each normal attack hits the enemy twice.""
2.24: Implemented in battle 2k. Needs testing in 2k3.

" Items: Effect: Ignore enemy dodge rate "Attack accuracy ignores the enemy's agility.""
Was partly implemented in #1259 but now in 3.19 is updated to consider both weapons.

" Items: Prevent Critical Hits "Enemy characters will not critically hit the wearer"."
3.18: Implemented.

"States: Accuracy modifier"
2.34: Implemented.

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Dec 12, 2018

@fmatthew5876
Could you take a look at this?

The current status should be the following (or pending a merge):

Implemented:

  • Actor: Dual Wield: "Equip Weapon with both hands". When doing a normal attack the attack animations of both weapons will play and the damage is the sum of both. Also needs testing if the Equipment Scene handles this
  • Items: Two handed (needs changes to Equipment scene?)
  • Items: Effect: Ignore enemy dodge rate "Attack accuracy ignores the enemy's agility."
  • Items: Negate Terrain damage "Damage from terrain will not be taken."
  • States: Accuracy modifier

Not sure:

  • Skills: States. The 2nd non-default option (Heal instead of Inflict) is not handled. (do we handle this?)
  • Items: Effect: Attack twice at the same time " Each normal attack hits the enemy twice." (do we handle this?)
  • Items: The 2nd option (heal instead of inflict) for states

Missing?:

  • Items: Effect: Player can't unequip. The equipment cannot be removed. (Needs a change to the Equipment scene)
  • Items: Player can't unequip "The equipment cannot be removed." - Equipment scene
  • States: Fixed Equipment "For as long as this state is active, weapons and equipment cannot be changed." - Needs change to equipment scene
@fmatthew5876

This comment has been minimized.

Copy link
Contributor

fmatthew5876 commented Dec 13, 2018

These are in master, please check them off.

  • Actor: Dual Wield: "Equip Weapon with both hands". When doing a normal attack the attack animations of both weapons will play and the damage is the sum of both. Also needs testing if the Equipment Scene handles this
  • Items: Two handed (needs changes to Equipment scene?)
  • Items: Effect: Ignore enemy dodge rate "Attack accuracy ignores the enemy's agility."
  • States: Accuracy modifier
  • Items: Negate Terrain damage "Damage from terrain will not be taken." (Note: I also tested the screen does not flash when entire party is protected)
  • Items: Effect: Attack twice at the same time " Each normal attack hits the enemy twice." (do we handle this?)

This is implemented for weapons. Need to check for armor that inflicts states.

  • Items: The 2nd option (heal instead of inflict) for states

The rest need to be checked further and/or implemented.

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

fmatthew5876 commented Dec 13, 2018

Regarding "Items: The 2nd option (heal instead of inflict) for states"..

I recommend splitting this into 2 tasks: weapons and armor.

As I mentioned, weapons are done.

Armor state inflict is more complicated. There are a lot of questions:
What happens if you try to remove the state from:

  • Medicine?
  • Skill?
  • weapon attack?
  • EventCommand: Remove State Actor
  • EventCommand: Remove State Monster
  • EventCommand: Full Recovery
  • EventCommand: Rest at the Inn
  • Other state inflicted with priority + 10?

Since its a 2k3 feature, I'd expect at least 1 or 2 of these to have bugs in RPG_RT.

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

fmatthew5876 commented Dec 13, 2018

* Items: Effect: Player can't unequip. The equipment cannot be removed. (Needs a change to the Equipment scene)

This is already in master

* Items: Player can't unequip "The equipment cannot be removed." - Equipment scene
* States: Fixed Equipment "For as long as this state is active, weapons and equipment cannot be changed." - Needs change to equipment scene

In #1562

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

fmatthew5876 commented Dec 13, 2018

Items: Effect: Preemptive Advantage during battle "Ignores agility and attacks at the beginning of the turn." Partly, not for 2k

This is fully implemented in 0.6

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Dec 13, 2018

okay so if I didnt mess this up this keeps us with.

  • Skills: States. The 2nd non-default option (Heal instead of Inflict) is not handled.
  • Items (Other): The 2nd option (heal instead of inflict) for states

I will move the enemy flipping in a different issue. Because this one will fall much later and is only visual

@Ghabry Ghabry modified the milestones: 0.7.0, 0.6.0 (likely) Dec 13, 2018

@Ghabry Ghabry removed the Needs feedback label Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment