Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Battle 2k - Shake screen is off by 1 frame for monsters #1735

Closed
fmatthew5876 opened this issue Mar 31, 2019 · 1 comment
Closed

Battle 2k - Shake screen is off by 1 frame for monsters #1735

fmatthew5876 opened this issue Mar 31, 2019 · 1 comment
Labels
Battle Patch available
Milestone
0.6.1

Comments

@fmatthew5876
Copy link
Contributor

Make a battle event which causes a slow, strong screen shake. You'll notice enemy sprites don't move in sync with the background.

Effects 2k battles. Maybe 2k3 also but haven't tested.
@fmatthew5876 fmatthew5876 changed the title Battle 2k - Shake screen is off by 1 frame Battle 2k - Shake screen is off by 1 frame for monsters Mar 31, 2019
fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Mar 31, 2019
@fmatthew5876
Battle: Fix screen effects timing
2c5013f 
Battler sprites shake position was off by 1 frame. To fix this,
we move the screen update to happen after the interpreter runs but
before we update battlers.

Fix EasyRPG#1735
@fdelapena fdelapena added this to the 0.6.1 milestone Mar 31, 2019
@fmatthew5876
Copy link
Contributor Author

Now fixed in #1726

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue May 1, 2019
@fmatthew5876
Battle: Fix screen effects timing
f9960f0 
Battler sprites shake position was off by 1 frame. To fix this,
we move the screen update to happen after the interpreter runs but
before we update battlers.

Fix EasyRPG#1735
fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue May 25, 2019
@fmatthew5876
Battle: Fix screen effects timing
8e81226 
Battler sprites shake position was off by 1 frame. To fix this,
we move the screen update to happen after the interpreter runs but
before we update battlers.

Fix EasyRPG#1735
fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue May 29, 2019
@fmatthew5876
Battle: Fix screen effects timing
469846d 
Battler sprites shake position was off by 1 frame. To fix this,
we move the screen update to happen after the interpreter runs but
before we update battlers.

Fix EasyRPG#1735
fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue May 31, 2019
@fmatthew5876
Battle: Fix screen effects timing
1fc231c 
Battler sprites shake position was off by 1 frame. To fix this,
we move the screen update to happen after the interpreter runs but
before we update battlers.

Fix EasyRPG#1735
fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Jun 6, 2019
@fmatthew5876
Battle: Fix screen effects timing
3b6a504 
Battler sprites shake position was off by 1 frame. To fix this,
we move the screen update to happen after the interpreter runs but
before we update battlers.

Fix EasyRPG#1735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Battle Patch available
Milestone
0.6.1
Development

No branches or pull requests
2 participants
@fdelapena @fmatthew5876