Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQ2: Battle doesn't end after defeating the Bomb Rock #1875

Closed
Ghabry opened this issue Aug 25, 2019 · 1 comment · Fixed by #1880
Closed

DQ2: Battle doesn't end after defeating the Bomb Rock #1875

Ghabry opened this issue Aug 25, 2019 · 1 comment · Fixed by #1880
Labels
Battle Patch available
Milestone
0.6.2

Comments

@Ghabry
Copy link
Member

Ghabry commented Aug 25, 2019

Name of the game:

DQ2　悪霊の勇者・製品版ver1.50

Attach files (as a .zip archive or link them)

Download: http://www1.axfc.net/uploader/so/1768371 (NFSW. full of hentai ads!)

  1. Click "[ 1768371.zipをダウンロードします。 ]"
  2. ＜ダウンロードする | click here to start download. ＞
  3. When the download doesn't start click on こちら

Savegame:
DQ2-Save05.zip

Describe the issue in detail and how to reproduce it:

Kill the enemy in front of you using fast forward and normal attacks.
When he dies the battle continues and selecting "Attack" again will crash the engine because the enemy list is empty.
@Ghabry Ghabry added the Battle label Aug 25, 2019
@Ghabry Ghabry added this to the 0.6.2 milestone Aug 25, 2019
fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Aug 27, 2019
@fmatthew5876
Fix compatibility with older save games
ce58078 
Fixes bug where save in EasyRPG#1875 would hang when loaded
@fmatthew5876 fmatthew5876 mentioned this issue Aug 27, 2019
Closed
fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Aug 27, 2019
@fmatthew5876
Battle2k: Fix bug in self destruct logic
b0f842f 
Self destruct would set the enemy as hidden, and then later
RemoveActionsForNonExistantBattlers() would remove it before
it completed, causing the next battle algorithm to start running
midway.

If the next algo was a defend or something with no target, it will
crash. If it's an attack, it can cause the battle not to finish.

Fix EasyRPG#1875
@fmatthew5876 fmatthew5876 mentioned this issue Aug 27, 2019
Merged
@fmatthew5876
Copy link
Contributor

Fixed by #1880

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Aug 28, 2019
@fmatthew5876
Fix compatibility with older save games
20f9342 
Fixes bug where save in EasyRPG#1875 would hang when loaded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Battle Patch available
Milestone
0.6.2
Development

Successfully merging a pull request may close this issue.

Battle2k: Fix bug in self destruct logic fmatthew5876/Player
3 participants
@fdelapena @fmatthew5876 @Ghabry