-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yume2kki: Maiden Outlook background not showing properly #2195
Comments
Looks like a bug with panorama positioning. Thanks for reporting. Is not a known bug |
I'll leave a debug save here to make this bug faster to find. |
Just a small update to this bug, it's still present in 0.6.2.3 as well as the continuous build I downloaded a few hours ago. By the way, for some reason, in 0.116 the menu no longer works in Maiden Outlook. (Not a bug, it's like that in RPG_RT too) |
The expected pan_x is When changing the panorama RPG_RT executes the following code: if ( !horScroll && !horLooping) {
a = 16 * mapWidth - 20;
b = max(0, imageWidth - 320);
c = min(a, b);
if ( b != 0 ) {
pan_x = 2 * c * camera_pan_x / a;
} else {
pan_x = 0;
}
} Player does: if (params.scroll_horz || LoopHorizontal()) {
panorama.pan_x = map_info.position_x;
} else if (GetWidth() > 20 && parallax_width > SCREEN_TARGET_WIDTH) {
panorama.pan_x = std::min(
map_info.position_x * (parallax_width - SCREEN_TARGET_WIDTH) * 2 / ((GetWidth() - 20) * TILE_SIZE),
map_info.position_x * 2);
}
} My guess is that this is also related to the async code: The image width is required but not available when determining it. Maybe make panorama change a blocking async op. |
In some cases (not scrolling or looping) the position is reset after loading the panorama. Here was the bug: Multiple ChangePanorama commands overwrote the reset indicator. Added a async yield op to the event and made the panorama image important to ensure that the image is loaded. Refactored Spriteset_Map to prevent deletion as the panorama change is otherwise a dangling reference. Fix EasyRPG#2195
In some cases (not scrolling or looping) the position is reset after loading the panorama. Here was the bug: Multiple ChangePanorama commands overwrote the reset indicator. Added a async yield op to the event and made the panorama image important to ensure that the image is loaded. Refactored Spriteset_Map to prevent deletion as the panorama change is otherwise a dangling reference. Fix EasyRPG#2195
Some more bugs reported: The door is misaligned: Must be like this: Then go down the stairs, watch out for the jumpscare (See below) Bug in the game, not a Player bug: When you go downstairs to the left there is a jump scare. Some quick flashing face. If you loaded the save, moved left, then right to the old room, left again and walk downstairs the face is misaligned: |
This is actually a difference between 2k and 2k3. The face is misaligned only in 2k3, in 2k it is correct. Here is a better savegame: Go through the door in front of you and then to the right until you see another door. With 2k: With 2k3: |
In some cases (not scrolling or looping) the position is reset after loading the panorama. Here was the bug: Multiple ChangePanorama commands overwrote the reset indicator. Added a async yield op to the event and made the panorama image important to ensure that the image is loaded. Refactored Spriteset_Map to prevent deletion as the panorama change is otherwise a dangling reference. Fix EasyRPG#2195
There was a regression when loading async in the Yume2kki balcony and in MAP0947 (Wooden Polycube Ruins). These are also fixed. |
Name of the game:
Yume2kki
Player platform:
Linux
Attach files (as a .zip archive or link them)
easyrpg_log.txt
Describe the issue in detail and how to reproduce it:
The Maiden Outlook area in 2kki looks weird in EasyRPG:


And here's how it's supposed to look:

To reproduce:
Start/Load a game and head to the Maiden Outlook. (Sleep > Nexus > Library (Entrance looks like a roof) > read the book on the second bookcase to the left of the Library's entrance.
(Sorry if this ends up being a duplicate.)
The text was updated successfully, but these errors were encountered: