Yume2kki: Maiden Outlook background not showing properly

[purupurupuruin]

Name of the game:

Yume2kki

Player platform:

Linux

Attach files (as a .zip archive or link them)

easyrpg_log.txt

Describe the issue in detail and how to reproduce it:

The Maiden Outlook area in 2kki looks weird in EasyRPG:

And here's how it's supposed to look:

To reproduce:
Start/Load a game and head to the Maiden Outlook. (Sleep > Nexus > Library (Entrance looks like a roof) > read the book on the second bookcase to the left of the Library's entrance.
(Sorry if this ends up being a duplicate.)

[Ghabry]

Looks like a bug with panorama positioning. Thanks for reporting. Is not a known bug

[purupurupuruin]

I'll leave a debug save here to make this bug faster to find.
maidenoutlook.zip

[purupurupuruin]

Just a small update to this bug, it's still present in 0.6.2.3 as well as the continuous build I downloaded a few hours ago.
Since I made that debug save in an older version of 2kki (0.112 I think), here's a debug save I made in 2kki ver 0.116 just in case:

maidenoutlook2.zip

By the way, for some reason, in 0.116 the menu no longer works in Maiden Outlook. (Not a bug, it's like that in RPG_RT too)

[Ghabry]

The expected pan_x is 8960.

When changing the panorama RPG_RT executes the following code:

if ( !horScroll && !horLooping) {
    a = 16 * mapWidth - 20;
    b = max(0, imageWidth - 320);
    c = min(a, b);
    if ( b != 0 ) {
      pan_x = 2 * c * camera_pan_x / a;
    } else {
      pan_x = 0;
    }
  }

Player does:

if (params.scroll_horz || LoopHorizontal()) {
	panorama.pan_x = map_info.position_x;
} else if (GetWidth() > 20 && parallax_width > SCREEN_TARGET_WIDTH) {
	panorama.pan_x = std::min(
		map_info.position_x * (parallax_width - SCREEN_TARGET_WIDTH) * 2 / ((GetWidth() - 20) * TILE_SIZE),
		map_info.position_x * 2);
	}
}

My guess is that this is also related to the async code: The image width is required but not available when determining it. Maybe make panorama change a blocking async op.

[Ghabry]

Save04.zip

Some more bugs reported:
Load the Save and move to the left and then return to the previous map (This is necessary because pan chunks are not saved)

The door is misaligned:

Must be like this:

Then go down the stairs, watch out for the jumpscare (See below)
In the next room the next issue:

Bug in the game, not a Player bug:

When you go downstairs to the left there is a jump scare. Some quick flashing face.

If you loaded the save, moved left, then right to the old room, left again and walk downstairs the face is misaligned:

[Ghabry]

This is actually a difference between 2k and 2k3.

The face is misaligned only in 2k3, in 2k it is correct.

Here is a better savegame: Go through the door in front of you and then to the right until you see another door.
Then you are in the red room again.

Save05.zip

With 2k:

With 2k3:

[Ghabry]

There was a regression when loading async in the Yume2kki balcony and in MAP0947 (Wooden Polycube Ruins). These are also fixed.