Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emscripten: shell file looks minified but also broken #2446

Closed
fdelapena opened this issue Jan 27, 2021 · 1 comment · Fixed by #2518
Closed

Emscripten: shell file looks minified but also broken #2446

fdelapena opened this issue Jan 27, 2021 · 1 comment · Fixed by #2518
Labels
Emscripten WebAssembly/JavaScript port for web browsers Patch available Regression
Milestone
0.7.0

Comments

@fdelapena
Copy link
Contributor

Somehow the index.html file in master breaks some elements, e.g. missing space in <!doctype html> or the meta viewport is messed with another meta tag:

Captura de pantalla de 2021-01-27 11-16-21

URL: https://easyrpg.org/play/master/
@fdelapena fdelapena added Emscripten WebAssembly/JavaScript port for web browsers Regression labels Jan 27, 2021
@fdelapena fdelapena added this to the 0.6.3 milestone Jan 27, 2021
@Ghabry
Copy link
Member

Ghabry commented May 3, 2021

Maybe this helps emscripten-core/emscripten#8547

Though is more a workaround.

Can be put in the CMakeLists

-s MINIFY_HTML=0

@fdelapena fdelapena mentioned this issue May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Emscripten WebAssembly/JavaScript port for web browsers Patch available Regression
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Emscripten: don't minify HTML shell on release build
3 participants
@fdelapena @Ghabry @carstene1ns