Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shop: Invalid item ID when buying #305

Closed
fdelapena opened this issue Jul 11, 2014 · 11 comments · Fixed by #313
Closed

Shop: Invalid item ID when buying #305

fdelapena opened this issue Jul 11, 2014 · 11 comments · Fixed by #313

Comments

@fdelapena
Copy link
Contributor

Possible regression

@Ghabry
Copy link
Member

Ghabry commented Jul 11, 2014

Yes was introduced in battle branch :/. Copy-Paste-Error.
Will fix it later.

@fdelapena fdelapena added this to the 0.3 milestone Jul 13, 2014
@captaincecil
Copy link

How is this coming along? Did you intend to fix this in the latest Wii nightly build? (July 13th 2014) Well items still don't work but I suppose I,m assuming that you intended to fix that issue in that the new one but good luck fixing the problem. I hope it's solved soon. Could you guys give me an update about the issue? How its coming along? Or maybe if I am making a mistake? Good luck! Reply soon.

@Zegeri
Copy link
Member

Zegeri commented Jul 14, 2014

Here's an update for you: fixed in 8b1f1a6.

@captaincecil
Copy link

Err...How do I work this? What do I do? Will this work with the latest Wii build? Do I download anything?

@Ghabry
Copy link
Member

Ghabry commented Jul 15, 2014

You can't do anything. You know that this is included when this issue got closed.

@captaincecil
Copy link

So I can just download the latest build and that file will be in there?

@fdelapena
Copy link
Contributor Author

fdelapena commented Jul 15, 2014

When this issue is marked as "closed" you will be able to get a build from https://ci.easyrpg.org/job/player-wii/ with the solution applied, won't be automatically built before.
The whole process works as follows:

  • Developers make changes on their code forks.
  • Once a developer considers these changes are ready, will open a pull request to merge them to the main fork. These summary of changes will mention which issue numbers fix.
  • There is an automated pull request building to check everything works and there is some review. If everything is fine, the pull can be merged.
  • Once the pull request is merged, the mentioned issues in the pull request will automatically close them.
  • The automated build system will start building all ports (Android, Wii...) and will generate a new binary.

@captaincecil
Copy link

Oh..So it isn't a closed issue yet? Well I guess I,ll have to wait. Well Thanks in advance.
Good luck! I hope you fix it soon! (It isn't closed yet, right?....)

@captaincecil
Copy link

Whoops..The page didnt load your explanation about the build process. I see now it is not closed
well good luck! Hope it goes along well. ( And how very intresting, by the way.)

@captaincecil
Copy link

How's it coming along? Is everything okay? Just thought I,d check on the latest progress.

@fdelapena
Copy link
Contributor Author

fdelapena commented Jul 18, 2014

@fdelapena fdelapena modified the milestones: 0.2.2, 0.3 Dec 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants