Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Show backslash/yen/won not working #388

Closed
fdelapena opened this issue Jan 3, 2015 · 3 comments
Closed

Regression: Show backslash/yen/won not working #388

fdelapena opened this issue Jan 3, 2015 · 3 comments
Labels
Patch available UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design Window/Scenes
Milestone
0.3

Comments

@fdelapena
Copy link
Contributor

As shown in TestGame-2000 test, map 0001:
Backslash yen or won not displayed

Relevant debug information:
[2015-01-03 17:10:55] Debug: Detected encoding: ibm-5348_P100-1997
For this case it should display a \ sign.
@fdelapena fdelapena added Window/Scenes UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design labels Jan 3, 2015
@fdelapena fdelapena added this to the 0.3 milestone Jan 3, 2015
@Zegeri
Copy link
Member

Zegeri commented Jan 8, 2015

I think this isn't a regression, but a mistake of mine months ago.
Anyway, fixed in 87f02d8.

@fdelapena
Copy link
Contributor Author

Thanks, tested and working, though U+20A9 (₩) is missing from shinonome is properly noticed in the debug log when testing Korean encoding as expected.

@rohkea
Copy link
Member

rohkea commented Jan 10, 2015

I'll add the Won symbol (together with more kanji) later.

@Ghabry Ghabry closed this as completed in 2687e5d Feb 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Patch available UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design Window/Scenes
Milestone
0.3
Development

No branches or pull requests
3 participants
@fdelapena @rohkea @Zegeri