Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pictures that "scroll with the map" are influenced by Pan #801

Closed
Ghabry opened this issue Mar 7, 2016 · 6 comments
Closed

Pictures that "scroll with the map" are influenced by Pan #801

Ghabry opened this issue Mar 7, 2016 · 6 comments

Comments

@Ghabry
Copy link
Member

Ghabry commented Mar 7, 2016

Terminology info because this is still confusing for me: This is wrong, see scurest comment
From a Player perspective "Scroll with map" means that they stay at the same position of the viewport because from a code perspective they move with the map when it scrolls... I would have called this "Fixed to screen", whatever...

Anyway when the screen is panned via that evt command by some tiles the picture does not stay at the same position of the viewport but scrolls away.

@scurest
Copy link
Contributor

scurest commented Mar 8, 2016

Isn't it the other way? When "Scroll Picture with Map" is checked, the picture is fixed to the map and is supposed to move off the screen when the map scrolls or pans, but when it's unchecked, the picture is fixed to the screen? Player and RPG_RT seem to do the same thing for both options when an event pans in a simple test.

@Ghabry
Copy link
Member Author

Ghabry commented Mar 8, 2016

As I said, it's confusing to me... And of course I explained it wrong :(
Good find ^^

@scurest
Copy link
Contributor

scurest commented Mar 8, 2016

lol :) The function of some of these check boxes is incredibly opaque.

@Ghabry
Copy link
Member Author

Ghabry commented Mar 8, 2016

The Show Picture Dialog has another nice "Feature": When you don't set any effect (e.g. rotating) then RPG 2000 will ignore rotating & co. effects in "Move Picture". But RPG 2003 won't :D.

But we couldn't find a game yet that breaks because of this (lucky!)

@carstene1ns
Copy link
Member

Player and RPG_RT seem to do the same thing for both options when an event pans in a simple test.

Does this mean it is not an issue anymore? Do we have a game as testcase?

@carstene1ns carstene1ns added the Needs feedback Waiting for the issue author to give further information. label Jul 31, 2016
@Ghabry
Copy link
Member Author

Ghabry commented Sep 1, 2016

Probably same problem as Yume Nikki spaceship scrolling... works for me

@Ghabry Ghabry closed this as completed Sep 1, 2016
@Ghabry Ghabry modified the milestones: 0.5.0, 0.6.0 Sep 1, 2016
@fdelapena fdelapena removed the Needs feedback Waiting for the issue author to give further information. label Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants