Add large CharSet support #1067

Merged
merged 1 commit into from Oct 30, 2016

Conversation

Projects
None yet
3 participants
@fdelapena
Contributor

fdelapena commented Oct 29, 2016

This recovers large CharSet support removed since #137 fix,
allowing CharSet files starting with a dollar sign to be
calculated by 4x2 SpriteSets. This differs from VX Ace behavior.
The purpose of using large 4x2 spritesets instead individual
spritesets like VX Ace does is to keep reduced file access
on games wanting to use multiple large characters.
Also keeps code lesser complicated for this custom feature.

Test case to use with the PR:
largecharset.zip

@fdelapena fdelapena added this to the 0.5.1 milestone Oct 29, 2016

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Oct 30, 2016

Member

Works for me and looks funny ;). More serious: This is a minimal change and conflicts with existing games are very unlikely. To break, the game must use a file with incorrect pixelsize and a $-prefix.

screenshot_0screenshot_1

Member

Ghabry commented Oct 30, 2016

Works for me and looks funny ;). More serious: This is a minimal change and conflicts with existing games are very unlikely. To break, the game must use a file with incorrect pixelsize and a $-prefix.

screenshot_0screenshot_1

@Ghabry

Ghabry approved these changes Oct 30, 2016

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Oct 30, 2016

Member

As mentiomed in chat output.h is a useless include but is probably a problem in general in the codebase ;)

Member

Ghabry commented Oct 30, 2016

As mentiomed in chat output.h is a useless include but is probably a problem in general in the codebase ;)

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Oct 30, 2016

Member

Yeah, I would have run include-what-you-use already to fix cases like this, but this tool is soo broken... 👎

Member

carstene1ns commented Oct 30, 2016

Yeah, I would have run include-what-you-use already to fix cases like this, but this tool is soo broken... 👎

Add large CharSet support
This recovers large CharSet support removed since #137 fix,
allowing CharSet files starting with a dollar sign to be
calculated by 4x2 SpriteSets. This differs from VX Ace behavior.
The purpose of using large 4x2 spritesets instead individual
spritesets like VX Ace does is to keep reduced file access
on games wanting to use multiple large characters.
Also keeps code lesser complicated for this custom feature.

@Ghabry Ghabry merged commit 7586d67 into EasyRPG:master Oct 30, 2016

6 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@fdelapena fdelapena deleted the fdelapena:large_charset branch Oct 31, 2016

Ghabry added a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment