Add large CharSet support #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me and looks funny ;). More serious: This is a minimal change and conflicts with existing games are very unlikely. To break, the game must use a file with incorrect pixelsize and a $-prefix.
|
Ghabry
approved these changes
Oct 30, 2016
carstene1ns
approved these changes
Oct 30, 2016
|
As mentiomed in chat output.h is a useless include but is probably a problem in general in the codebase ;) |
|
Yeah, I would have run |
This recovers large CharSet support removed since #137 fix, allowing CharSet files starting with a dollar sign to be calculated by 4x2 SpriteSets. This differs from VX Ace behavior. The purpose of using large 4x2 spritesets instead individual spritesets like VX Ace does is to keep reduced file access on games wanting to use multiple large characters. Also keeps code lesser complicated for this custom feature.
Ghabry
added a commit
to libretro/easyrpg-libretro
that referenced
this pull request
May 22, 2018
Add large CharSet support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This recovers large CharSet support removed since #137 fix,
allowing CharSet files starting with a dollar sign to be
calculated by 4x2 SpriteSets. This differs from VX Ace behavior.
The purpose of using large 4x2 spritesets instead individual
spritesets like VX Ace does is to keep reduced file access
on games wanting to use multiple large characters.
Also keeps code lesser complicated for this custom feature.
Test case to use with the PR:
largecharset.zip