Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Screen flash fixes #1501
Continuous flashing is broken in rm2k3 with save games in a unique way.
If you save your game, and then go to end game, and load without exiting
If you close
I haven't tested but I bet if you save and load different save games you could get surprises. Like save one game with a short continuous flash, and then load a different one with a longer continuous flash. I expect the load would continue with the short flash.
It looks like some state is kept to keep the flash going which is left in memory when you go back to the title and reload.
I'm very confused how it even works. In order for you to be able to repeat the flash, you need to store the original time amount and saturation so that the program knows how to repeat the same flash. The
There appears no chunk in the save data to store these extra 2 values.
@CherryDT How are they doing it in rm2k3?
Our algorithm for shake screen looks wrong. It doesn't work at all for some values of speed and power.
@CherryDT What is the algorithm used for computing
Also are these flash and shake effects computed in terms of 1/10 s or frames? It seems the time left is in 1/10 s units.
If its in 1/10 s, our timing is also wrong as it looks like we increment these every frame??