Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to C++14 / Gcc5 #1882

Merged
merged 1 commit into from Sep 26, 2019
Merged

Migrate to C++14 / Gcc5 #1882

merged 1 commit into from Sep 26, 2019

Conversation

fmatthew5876
Copy link
Contributor

Depends on: EasyRPG/liblcf#339

configure.ac Outdated Show resolved Hide resolved
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs changes to all the Makefiles in the builds directory because they are still not migrated to CMake ^^'. (don't forget Android, that Makefile is a bit hidden)

@fmatthew5876
Copy link
Contributor Author

Added to all the make files, including secret android ones.

@Ghabry Ghabry added this to the 0.6.2 milestone Sep 3, 2019
configure.ac Outdated
@@ -112,7 +112,7 @@ AC_SUBST([BASHCOMPLETION_DIR])
AM_CONDITIONAL([HAVE_BASHCOMPLETION], [test "x$with_bash_completion_dir" != "xno"])

# C++11 is mandatory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "# C++14 is mandatory"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@Ghabry Ghabry merged commit e7d37f8 into EasyRPG:master Sep 26, 2019
@fmatthew5876 fmatthew5876 deleted the cxx14 branch January 16, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

5 participants