Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DynamicFormat and Bitmap formats_map constexpr #1960

Merged
merged 2 commits into from Dec 13, 2019
Merged

Make DynamicFormat and Bitmap formats_map constexpr #1960

merged 2 commits into from Dec 13, 2019

Conversation

fmatthew5876
Copy link
Contributor

@fmatthew5876 fmatthew5876 commented Dec 1, 2019 •
edited

Depends on #1959

Make this a separate PR because it likely breaks GCW0 build despite being C++14 compliant.

This allows us to remove lazy initialization. It also removes startup runtime code to construct the mapping.

@fmatthew5876 fmatthew5876 mentioned this pull request Dec 1, 2019
Merged
@fmatthew5876 fmatthew5876 force-pushed the bitmap_opt2 branch 2 times, most recently from 3071885 to e67a1ac Compare December 4, 2019 14:06
@fdelapena fdelapena added Building Performance Related to improvements on memory, less CPU or disk usage, battery savings, etc. labels Dec 6, 2019
@fdelapena fdelapena added this to the 0.6.2 milestone Dec 6, 2019
Ghabry
Ghabry approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I don't consider GCW Zero critical I'm fine with merging this right now

@fdelapena fdelapena merged commit 42bcee9 into EasyRPG:master Dec 13, 2019
@fmatthew5876 fmatthew5876 deleted the bitmap_opt2 branch January 16, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdelapena fdelapena fdelapena approved these changes

@Ghabry Ghabry Ghabry approved these changes

Assignees
No one assigned
Labels
Building Performance Related to improvements on memory, less CPU or disk usage, battery savings, etc.
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmatthew5876 @fdelapena @Ghabry