Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constexpr compilation in Game_Character #2247

Merged
merged 1 commit into from Jun 18, 2020
Merged

Fix constexpr compilation in Game_Character #2247

merged 1 commit into from Jun 18, 2020

Conversation

fmatthew5876
Copy link
Contributor

@fmatthew5876 fmatthew5876 commented Jun 14, 2020 •
edited

Fix: #2246

@Ghabry
Copy link
Member

Ghabry commented Jun 16, 2020

Have to setup the right gcc compiler first, maybe gcc5 really works and broken since 5.1

@carstene1ns carstene1ns added this to the 0.6.3 milestone Jun 16, 2020
Ghabry
Ghabry approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be backported to stable. Fixes 0.6.2.1 build 👍

@Ghabry Ghabry merged commit 6e8e950 into EasyRPG:master Jun 18, 2020
@carstene1ns carstene1ns added the backport to stable Pull requests with changes backported to our stable, maintenance branch label Jun 18, 2020
@fmatthew5876 fmatthew5876 deleted the cexprfix branch June 18, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdelapena fdelapena fdelapena approved these changes

@Ghabry Ghabry Ghabry approved these changes

@carstene1ns carstene1ns carstene1ns approved these changes

Assignees
No one assigned
Labels
backport to stable Pull requests with changes backported to our stable, maintenance branch Building
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

Some constexpr code fails to compile on GCC < 7.2
4 participants
@fmatthew5876 @Ghabry @fdelapena @carstene1ns